Fixes parity tests failures in windows machines. #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string in windows machines.
sameer-google
requested review from
sameer-google
and removed request for
sameer-google
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gsutil rsyncparity tests are failing in windows machine because of pipe character. Pipe character,|, is a special character for winodws cmd and it should escaped while being used in command input. Windows cmd treats^character as escape character and can be used to escape pipe character as well but it works only for internal windows commands and fails to escape for external commands.It appears that
^^^string is correctly escaping pipe character even though there is no official windows documentation related to this.This PR modifies rsync test check which is testing pipe character in regex input. Since it needs to be escaped for windows machines, I have added a separate condition to format input incase of windows shim only mode.