feat: drop support for Python 3.8 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatgadkar-goog
force-pushed
the
drop-python-3.8
branch
2 times, most recently
from
f79ba47
to
fb8937b
Compare
rhatgadkar-goog
changed the title
enocom
approved these changes
Oct 30, 2024
|
Also you'll need to update the required checks to swap 3.9 for 3.8. |
Python 3.8 EOL was October 7, 2024: https://endoflife.date/python
rhatgadkar-goog
force-pushed
the
drop-python-3.8
branch
from
fb8937b
to
c9f3343
Compare
These are the ones I update in the branch protection settings? |
I updated the branch protection settings, and it looks like the required checks are for 3.9 now. So I guess that was it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 EOL was October 7, 2024: https://endoflife.date/python