Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #381

Closed
enocom opened this issue Oct 21, 2024 · 7 comments · Fixed by #383 or #386
Closed

Add support for Python 3.13 #381

enocom opened this issue Oct 21, 2024 · 7 comments · Fixed by #383 or #386
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Oct 21, 2024

See GoogleCloudPlatform/cloud-sql-python-connector#1177 for reference.

@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 21, 2024
@enocom
Copy link
Member Author

enocom commented Oct 21, 2024

@enocom
Copy link
Member Author

enocom commented Oct 21, 2024

Also, we should match Cloud SQL and drop Python 3.8. See GoogleCloudPlatform/cloud-sql-python-connector#1176.

@jackwotherspoon
Copy link
Collaborator

Python 3.13 was added in asyncpg 0.30.0 so once #375 is merged this should be good to go

@rhatgadkar-goog rhatgadkar-goog linked a pull request Oct 24, 2024 that will close this issue
@rhatgadkar-goog
Copy link
Collaborator

After #375 is merged, do we need to modify setup.py so that its asyncpg version is >= 0.30.0?: https://github.com/GoogleCloudPlatform/alloydb-python-connector/blob/main/setup.py#L80

@jackwotherspoon
Copy link
Collaborator

After #375 is merged, do we need to modify setup.py so that its asyncpg version is >= 0.30.0?: https://github.com/GoogleCloudPlatform/alloydb-python-connector/blob/main/setup.py#L80

That is a good question and one that I have been thinking about. Since we don't pin to a specific version, if the asyncpg package is not already installed in the environment pip will download the latest version by default, so fresh Python 3.13 installs would get 0.30.0 automatically with our current setup.

However since we are planning to document native asyncpg pool support with the Connector #382 which was also added in v0.30.0 then I think between the two of these it is worth pinning to >=0.30.0 in setup.py.

For Cloud SQL I am going to pin to v0.30.0 as part of adding native connection pool examples.

@rhatgadkar-goog
Copy link
Collaborator

I agree with you. I'll also pin to v0.30.0 as part of adding native connection pool examples in #382

@rhatgadkar-goog rhatgadkar-goog linked a pull request Oct 30, 2024 that will close this issue
@jackwotherspoon
Copy link
Collaborator

Looks like this was linked to the dropping of Python 3.8 PR by accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
3 participants