Switch localhost development to port 7777. #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
force-pushed
the
20241023-switch-local-dev-to-port-8888
branch
from
e0a0b01
to
7ad040b
Compare
DanielRyanSmith
approved these changes
Oct 23, 2024
KyleJu
reviewed
Oct 23, 2024
There was a problem hiding this comment.
I still see the usage of this port after a quick search
Should they be changed?
The gen code is OK because we are not using that generated server. The package.json reference is OK because that is for viewing test coverage, which we rarely do... although I suppose it could be confusing if you tried and failed to access the coverage report because you had a local webstatus.dev running. The datastore viewer mentioned in the .devcontainer/README file is trickier. I could move it to a different port, or maybe move the chromestatus app to a different port. |
KyleJu
approved these changes
Oct 24, 2024
jrobbins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent conflicts with ports used for local development of webstatus.dev.