Skip to content

Commit

Permalink
Switch localhost development to port 8888.
Browse files Browse the repository at this point in the history
  • Loading branch information
jrobbins committed Oct 23, 2024
1 parent fcd6de2 commit 7ad040b
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ To start the main server and the notifier backend, run:
```bash
npm start
```
Then visit `http://localhost:8080/`.
Then visit `http://localhost:8888/`.

To start front end code watching (sass, js lint check, babel, minify files), run

Expand Down Expand Up @@ -128,7 +128,7 @@ Chromestatus currently gets the list of Blink components from the file `hack_com

#### Seed the blink component owners

Visit http://localhost:8080/admin/blink/populate_blink to see the list of Blink component owners.
Visit http://localhost:8888/admin/blink/populate_blink to see the list of Blink component owners.

#### Debugging / settings

Expand Down
2 changes: 1 addition & 1 deletion framework/cloud_tasks_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def queue_path(self, project, location, queue):
def create_task(self, parent=None, task=None, **kwargs):
"""Immediately hit the target URL."""
uri = task.get('app_engine_http_request').get('relative_uri')
target_url = 'http://localhost:8080' + uri
target_url = 'http://localhost:8888' + uri
body = task.get('app_engine_http_request').get('body')
logging.info('Making request to %r', target_url)
handler_response = requests.request('POST',
Expand Down
2 changes: 1 addition & 1 deletion framework/cloud_tasks_helpers_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def test_create_task(self, mock_fetch):
self.assertIsNone(actual)
mock_fetch.assert_called_once_with(
'POST',
'http://localhost:8080/handler',
'http://localhost:8888/handler',
data=b'{"a": 1}',
allow_redirects=False,
headers={'X-AppEngine-QueueName': 'default'})
Expand Down
4 changes: 2 additions & 2 deletions gen/py/chromestatus_openapi/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ RUN pip3 install --no-cache-dir -r requirements.txt

COPY . /usr/src/app

EXPOSE 8080
EXPOSE 8888

ENTRYPOINT ["python3"]

CMD ["-m", "chromestatus_openapi"]
CMD ["-m", "chromestatus_openapi"]
2 changes: 1 addition & 1 deletion main.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,4 +367,4 @@ class Route:
# This is used when running locally only. When deploying to Google App
# Engine, a webserver process such as Gunicorn will serve the app. This
# can be configured by adding an `entrypoint` to app.yaml.
app.run(host='127.0.0.1', port=8080)
app.run(host='127.0.0.1', port=8888)
2 changes: 1 addition & 1 deletion packages/playwright/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ services:
command: bash -c "source cs-env/bin/activate; env && whoami && npm run start-app"
network_mode: host
healthcheck:
test: ["CMD", "curl", "-f", "http://localhost:8080"]
test: ["CMD", "curl", "-f", "http://localhost:8888"]
interval: 30s
timeout: 10s
retries: 10
Expand Down
4 changes: 2 additions & 2 deletions packages/playwright/playwright.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = defineConfig({
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
use: {
/* Base URL to use in actions like `await page.goto('/')`. */
baseURL: 'http://localhost:8080',
baseURL: 'http://localhost:8888',

/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: 'on-first-retry',
Expand Down Expand Up @@ -98,7 +98,7 @@ module.exports = defineConfig({
/* Run your local dev server before starting the tests */
webServer: {
command: 'npm run start',
url: 'http://localhost:8080',
url: 'http://localhost:8888',
reuseExistingServer: true,
},
});
2 changes: 1 addition & 1 deletion packages/playwright/wait-for-app.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash
# echo "waiting for backend to come up"
while [[ "$(curl --connect-timeout 2 -s -o /dev/null -w ''%{http_code}'' http://localhost:8080)" != "200" ]]; do
while [[ "$(curl --connect-timeout 2 -s -o /dev/null -w ''%{http_code}'' http://localhost:8888)" != "200" ]]; do
echo ..
sleep 10
done
Expand Down
2 changes: 1 addition & 1 deletion scripts/start_server.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export GAE_ENV='localdev'
export DATASTORE_EMULATOR_HOST=${DATASTORE_EMULATOR_HOST:-'localhost:15606'}


gunicorn --bind :8080 --workers 4 main:app
gunicorn --bind :8888 --workers 4 main:app


# TODO(jrobbins): Consider switching back to dev_appserver when
Expand Down

0 comments on commit 7ad040b

Please sign in to comment.