Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Description for Dehydrated Carps #11

Merged
merged 3 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Resources/Locale/en-US/_SSS/store_items.ftl
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
uplink-carp-box-name = Dehydrated Carp Box
uplink-carp-box-desc = Box filled with 4 dehydrated carps. Make sure your friends pet it as well!
uplink-carp-box-desc = Box filled with 4 dehydrated carps. Make sure your friends pet them as well!

uplink-disruptive-throwable-name = Disruptive Grenade Kit
uplink-disruptive-throwable-desc = A set of 1 flash, smoke and stinger grenades. Perfect for slowing down and getting away.

uplink-exploding-syndicate-bomb-SSS-desc = A big, anchored bomb that can create a huge explosion if not defused in time. Useful as a distraction. Has an adjustable timer with a minimum setting of 90 seconds. Stays quiet for 30 seconds upon activation.
uplink-armour-upgrade-name = Armour Upgrade Kit
uplink-armour-upgrade-desc = An armour upgrade kit. Use on your armour to upgrade the protection. Armour will drop if equipped!
uplink-armour-upgrade-desc = An armour upgrade kit. Use on your armour to upgrade the protection. Armour will drop if equipped!
2 changes: 1 addition & 1 deletion Resources/Prototypes/_SSS/Objects/store_items.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
parent: BoxCardboard
id: BoxDehydratedCarp
name: dehydrated carp box
description: uplink-carp-box-desc
description: Box filled with 4 dehydrated carps. Make sure your friends pet them as well!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way its currently set up, this will ignore uplink-carp-box-desc set in the .ftl file.

Suggested change
description: Box filled with 4 dehydrated carps. Make sure your friends pet them as well!
description: uplink-carp-box-desc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The item itself seems to completely ignore the locale file. It is only ever parsed for stuff like the traitor uplink menu. Not the object itself. If you check in game, the description of the entity is literally just "uplink-carp-box-desc"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

suffix: Traitor
components:
- type: StorageFill
Expand Down
Loading