Fixed: Description for Dehydrated Carps #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind role entities are failing. Completely unsure why... |
Simyon264
requested changes
Oct 21, 2024
| @@ -2,7 +2,7 @@ | |||
| parent: BoxCardboard | |||
| id: BoxDehydratedCarp | |||
| name: dehydrated carp box | |||
| description: uplink-carp-box-desc | |||
| description: Box filled with 4 dehydrated carps. Make sure your friends pet them as well! | |||
There was a problem hiding this comment.
The way its currently set up, this will ignore uplink-carp-box-desc set in the .ftl file.
Suggested change
| description: Box filled with 4 dehydrated carps. Make sure your friends pet them as well! | |
| description: uplink-carp-box-desc |
There was a problem hiding this comment.
The item itself seems to completely ignore the locale file. It is only ever parsed for stuff like the traitor uplink menu. Not the object itself. If you check in game, the description of the entity is literally just "uplink-carp-box-desc"
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Locales don't work on entity descriptions, fixed some wording as well
Requirements
Breaking changes
N/A
Changelog
🆑