Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Move Old SDK tests to 13 - Currently disabled #2262

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

polqf
Copy link
Contributor

@polqf polqf commented Aug 31, 2022

📝 Summary

Smoke tests running on Xcode 12 are failing because xcversion fails to find the application.
Reason described here: xcpretty/xcode-install#465
We are preparing old SDK smoke tests to run on Xcode 13 instead of 12, but disabling them for now until Xcode 14 is used.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

@polqf polqf marked this pull request as ready for review August 31, 2022 14:00
@polqf polqf requested a review from a team as a code owner August 31, 2022 14:00
@polqf polqf changed the title Xcode 12 CI Issue [Internal] Move Old SDK tests to 13 - Currently disabled Aug 31, 2022
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@polqf polqf merged commit cb2525d into develop Aug 31, 2022
@polqf polqf deleted the bugfix/xcode12-ci branch August 31, 2022 14:29
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

polqf added a commit that referenced this pull request Sep 1, 2022
* Move 'old SDK' regression to 13

* Disable Xcode 13 regression until Xcode 14 is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants