[Internal] Move Old SDK tests to 13 - Currently disabled (#2262)

* Move 'old SDK' regression to 13 * Disable Xcode 13 regression until Xcode 14 is used
GetStream · Sep 1, 2022 · 86abebf · 86abebf
1 parent 8878168
commit 86abebf
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 25 deletions.
diff --git a/.github/workflows/smoke-checks.yml b/.github/workflows/smoke-checks.yml
@@ -164,27 +164,29 @@ jobs:
       run: echo "::set-output name=launch_id::${{env.LAUNCH_ID}}"
       if: env.LAUNCH_ID != ''
 
-  build-xcode12:
-    name: Build LLC + UI (Xcode 12)
-    runs-on: macos-11
-    if: ${{ github.event_name != 'push' }}
-    steps:
-    - uses: actions/checkout@v2
-    - uses: ./.github/actions/bootstrap
-    - name: Build LLC (Xcode 12)
-      run: bundle exec fastlane test device:"iPhone 12" build_for_testing:true
-      timeout-minutes: 25
-      env:
-        XCODE_VERSION: "12.5.1"
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        GITHUB_EVENT: ${{ toJson(github.event) }}
-    - name: Build UI (Xcode 12)
-      run: bundle exec fastlane test_ui device:"iPhone 12" build_for_testing:true
-      timeout-minutes: 25
-      env:
-        XCODE_VERSION: "12.5.1"
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        GITHUB_EVENT: ${{ toJson(github.event) }}
+  # build-xcode13:
+  #   name: Build LLC + UI (Xcode 13)
+  #   runs-on: macos-12
+  #   if: ${{ github.event_name != 'push' }}
+  #   steps:
+  #   - uses: actions/checkout@v2
+  #   - uses: ./.github/actions/bootstrap
+  #   - name: List Xcode versions xcversion sees
+  #     run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'"
+  #   - name: Build LLC (Xcode 13)
+  #     run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true
+  #     timeout-minutes: 25
+  #     env:
+  #       XCODE_VERSION: "13"
+  #       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  #       GITHUB_EVENT: ${{ toJson(github.event) }}
+  #   - name: Build UI (Xcode 13)
+  #     run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true
+  #     timeout-minutes: 25
+  #     env:
+  #       XCODE_VERSION: "13"
+  #       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  #       GITHUB_EVENT: ${{ toJson(github.event) }}
 
   build-apps:
     name: Build Sample + Demo Apps

diff --git a/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift b/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift
@@ -2170,8 +2170,8 @@ final class ChannelController_Tests: XCTestCase {
 
         waitForExpectations(timeout: 0.1)
 
-        let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
-        guard case let .lessThan(paginationMessageId) = paginatonParameter else {
+        let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
+        guard case let .lessThan(paginationMessageId) = paginationParameter else {
             XCTFail("Missing pagination parameter")
             return
         }
@@ -2212,8 +2212,8 @@ final class ChannelController_Tests: XCTestCase {
 
         waitForExpectations(timeout: 0.1)
 
-        let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
-        guard case let .lessThan(paginationMessageId) = paginatonParameter else {
+        let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
+        guard case let .lessThan(paginationMessageId) = paginationParameter else {
             XCTFail("Missing pagination parameter")
             return
         }