Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update de_de.json #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update de_de.json #99

wants to merge 2 commits into from

Conversation

RazzorX
Copy link

@RazzorX RazzorX commented Jul 22, 2024

  • structure adjusted
  • added new entries
  • fixed a few lines
  • removed old lines that no longer exist

RazzorX added 2 commits July 22, 2024 17:01
- structure adjusted
- added new entries
- fixed a few lines
- removed old lines that no longer exist
- updated with the latest changes
Copy link
Contributor

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

"world-host.outdated_world_host": "Veraltetes World Host!",
"world-host.outdated_world_host.desc": "Du verwendest eine ältere Version von World Host (%s). Es wird empfohlen, auf %s zu aktualisieren.",
"world-host.outdated_world_host": "Veraltete World Host-Mod!",
"world-host.outdated_world_host.desc": "Du verwendest eine ältere Version von World Host (%s). Es wird empfohlen, auf Version %s zu aktualisieren.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding "Version" before %s? The original translation doesn't contain it

"world-host.config.onlineStatusLocation": "Online-Status Standort",
"world-host.config.title": "World Host-Einstellungen",
"world-host.config.serverIp": "Serveradresse",
"world-host.config.onlineStatusLocation": "Position Online-Status",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "Online-Status Position" instead?

"world-host.went_online": "%s ist nun online",
"world-host.went_online.desc": "Klicke hier oder Gehe zum Multiplayer-Menü, um ihnen beizutreten",
"world-host.went_online.desc": "Klicke hier oder gehe in das Mehrspieler-Menü um beizutreten",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the "ihnen" now

"world-host.friends.remove.message": "Du kannst sie später jederzeit wieder hinzufügen.",
"world-host.friends.bedrock_notice": "Verwalte Bedrock-Freunde auf der %s.",
"world-host.friends.bedrock_notice.link": "Xbox-Website",
"world-host.friends.remove.message": "Du kannst ihn später jederzeit wieder hinzufügen.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's your reasoning for sie->ihn, isn't sie more fitting for them?

Copy link
Owner

@Gaming32 Gaming32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one missed thing, since the UPnP option is inverted from what it was.

"world-host.config.enableFriends.tooltip": "Aktiviert alle auf Freunde bezogenen Menüs und das gesamte Freundesystem.\nWenn du es deaktivierst und wieder aktivierst, sind alle deine Freunde noch da.",
"world-host.config.enableReconnectionToasts": "Wiederverbindungsanzeige aktivieren",
"world-host.config.UPnP": "UPnP benutzen",
"world-host.config.UPnP.tooltip": "UPnP ist ein Mechanismus, der für eine direkte Verbindung verwendet werden kann. Allerdings treten dabei manchmal seltsame Probleme auf.\nAktiviere diese Einstellung, wenn Leute Probleme haben, sich über die Freundesliste oder der Tempip mit dir zu verbinden.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people are having issues, the correct course of action is to disable this option, not enable it.

@Gaming32 Gaming32 added the enhancement New feature or request label Dec 4, 2024
@Gaming32
Copy link
Owner

If this PR isn't updated by 2025-02-08, it will be closed to let others feel free to open a PR to update German translations. If it is updated after then, it will be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants