994 detect collisions for voxel vs voxel and voxel vs box #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luishfonseca
requested changes
Jul 8, 2024
RiscadoA
requested changes
Jul 10, 2024
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
2 times, most recently
from
559880d
to
27bdc7b
Compare
|
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
2 times, most recently
from
f555261
to
b1ab269
Compare
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
2 times, most recently
from
7c068bc
to
cf80a43
Compare
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
2 times, most recently
from
45a6bcf
to
fecd7ae
Compare
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
from
fecd7ae
to
fa5732f
Compare
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
from
fa5732f
to
9a654da
Compare
joaomanita
force-pushed
the
994-detect-collisions-for-voxel-vs-voxel
branch
from
9a654da
to
8f5a1f1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| for (uint z = start.z; z <= end.z; z++) | ||
| { | ||
| if (grid.get({end.x + 1, y, z}) == 0U || processed[end.x + 1][y][z]) |
There was a problem hiding this comment.
either cast from unsigned int to std::vector::size_type (aka unsigned long) is ineffective, or there is loss of precision before the conversion
| { | ||
| for (uint z = start.z; z <= end.z; z++) | ||
| { | ||
| if (grid.get({x, end.y + 1, z}) == 0U || processed[x][end.y + 1][z]) |
There was a problem hiding this comment.
either cast from unsigned int to std::vector::size_type (aka unsigned long) is ineffective, or there is loss of precision before the conversion
| { | ||
| for (uint y = start.y; y <= end.y; y++) | ||
| { | ||
| if (grid.get({x, y, end.z + 1}) == 0U || processed[x][y][end.z + 1]) |
There was a problem hiding this comment.
either cast from unsigned int to std::vector<bool, type-parameter-0-0>::size_type (aka unsigned long) is ineffective, or there is loss of precision before the conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a voxel collision shape which decomposes a voxel grid into a set of boxes to be used in collision detection.
Added a greedy meshing like algorithm to do the decomposing into boxes.
Added systems to detect collisions between voxel collision shapes and box shapes, and voxel-voxel.
Checklist