Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align prop and misc identifier requirements for the official FedRAMP namespace #773

Closed
11 of 16 tasks
aj-stein-gsa opened this issue Oct 11, 2024 · 8 comments · Fixed by #828, #774 or GSA/automate.fedramp.gov#102
Closed
11 of 16 tasks

Align prop and misc identifier requirements for the official FedRAMP namespace #773

aj-stein-gsa opened this issue Oct 11, 2024 · 8 comments · Fixed by #828, #774 or GSA/automate.fedramp.gov#102
Assignees
@Rene2mt
Labels
enhancement New feature or request scope: baselines scope: constraints scope: documentation scope: examples scope: templates

Comments

@aj-stein-gsa
Copy link
Contributor

aj-stein-gsa commented Oct 11, 2024 •
edited by Rene2mt
Loading

This is a ...

improvement - something could be better

This relates to ...

  • the FedRAMP OSCAL Registry
  • the FedRAMP OSCAL baselines
  • the Guide to OSCAL-based FedRAMP Content
  • the Guide to OSCAL-based FedRAMP System Security Plans (SSP)
  • the Guide to OSCAL-based FedRAMP Security Assessment Plans (SAP)
  • the Guide to OSCAL-based FedRAMP Security Assessment Results (SAR)
  • the Guide to OSCAL-based FedRAMP Plan of Action and Milestones (POA&M)
  • the FedRAMP SSP OSCAL Template (JSON or XML Format)
  • the FedRAMP SAP OSCAL Template (JSON or XML Format)
  • the FedRAMP SAR OSCAL Template (JSON or XML Format)
  • the FedRAMP POA&M OSCAL Template (JSON or XML Format)
  • the FedRAMP OSCAL Validations

User Story

As a developer of OSCAL-based tools for FedRAMP documentation, I would like alignment on the properties @ns, @system and other identifier URIs that FedRAMP uses in different variations in their customization of the upstream custom models.

Goals

Dependencies

N/A

Acceptance Criteria

  • All FedRAMP Documents Related to OSCAL Adoption (https://github.com/GSA/fedramp-automation) affected by the changes in this issue have been updated.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.

Other information

  1. Add reference to 774 PR for item 1 in goals
@aj-stein-gsa aj-stein-gsa moved this from 🆕 New to 📋 Backlog in FedRAMP Automation Oct 11, 2024
@aj-stein-gsa
Copy link
Contributor Author

@Rene2mt volunteer to start this off for now and work on the ADR to start.

@Rene2mt Rene2mt mentioned this issue Oct 11, 2024
Merged
7 tasks
@aj-stein-gsa aj-stein-gsa moved this from 📋 Backlog to 🔖 Ready in FedRAMP Automation Oct 23, 2024
@aj-stein-gsa aj-stein-gsa moved this from 🔖 Ready to 🏗 In progress in FedRAMP Automation Oct 23, 2024
@aj-stein-gsa aj-stein-gsa moved this from 🏗 In progress to 👀 In review in FedRAMP Automation Oct 24, 2024
@Rene2mt
Copy link
Member

Rene2mt commented Oct 25, 2024

Drafted the ADR (PR #774 ) but next, need to stage changes to constraints and add another PR for the documentation site. Moving this back to in progress.

@Rene2mt Rene2mt moved this from 👀 In review to 🏗 In progress in FedRAMP Automation Oct 25, 2024
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Oct 28, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
968a9a3
This was referenced Oct 28, 2024
Merged
Merged
@Rene2mt
Copy link
Member

Rene2mt commented Oct 28, 2024

@aj-stein-gsa we're going to keep this open for a bit and try to get feedback, so I didn't want to move it to "review". The changes are small / simple but in a lot of places (the PRs touch a lot of files).

Once we're ready, I'll rebase the associated PRs and formally move to "review".

@aj-stein-gsa
Copy link
Contributor Author

@aj-stein-gsa we're going to keep this open for a bit and try to get feedback, so I didn't want to move it to "review". The changes are small / simple but in a lot of places (the PRs touch a lot of files).

Once we're ready, I'll rebase the associated PRs and formally move to "review".

OK, got it. Sorry I read the email updates in the wrong order. 😆 Ignore my comment on #828 then.

@aj-stein-gsa aj-stein-gsa moved this from 🏗 In progress to 👀 In review in FedRAMP Automation Oct 28, 2024
@vmangat
Copy link

vmangat commented Oct 30, 2024

Consistency is good.

This was linked to pull requests Oct 31, 2024
Fix constraints and constraint test files per issue #773 #828
Merged
Update system identifier-type and FedRAMP extension namespaces - Issue 773 #774
Merged
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Nov 27, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
aa4576c
@Rene2mt
Copy link
Member

Rene2mt commented Dec 2, 2024

Putting on hold for a few more days in case there is any final feedback after the upcoming OSCAL implementers.

@Rene2mt Rene2mt moved this from 👀 In review to 🔖 Ready in FedRAMP Automation Dec 2, 2024
@aj-stein-gsa
Copy link
Contributor Author

@Rene2mt, I forgot to follow up after today's standup. I am giving you the go ahead to move this forward. Do you need help rebasing? Either way, let's discuss tomorrow.

@Rene2mt Rene2mt moved this from 🔖 Ready to 🏗 In progress in FedRAMP Automation Dec 11, 2024
@Rene2mt Rene2mt linked a pull request Dec 12, 2024 that will close this issue
Fix namespace, identifier-type and system per issue #773 GSA/automate.fedramp.gov#102
Merged
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Dec 12, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
d47ec88
@Rene2mt Rene2mt moved this from 🏗 In progress to 👀 In review in FedRAMP Automation Dec 12, 2024
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Dec 13, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
e9648fd
@Gabeblis Gabeblis mentioned this issue Dec 13, 2024
Closed
7 tasks
@Gabeblis Gabeblis linked a pull request Dec 13, 2024 that will close this issue
Fix Namespace Issue #773 #998
Closed
7 tasks
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Dec 18, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
79ec4b1
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Dec 20, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
c2bcaf2
Rene2mt added a commit to Rene2mt/fedramp-automation that referenced this issue Dec 20, 2024
@Rene2mt
Fix constraints and constraint test files per issue GSA#773
1ea8548
aj-stein-gsa added a commit that referenced this issue Dec 20, 2024
@Rene2mt @aj-stein-gsa
Fix constraints and constraint test files per issue #773 (#828)
b79ec53 
* Fix constraints and constraint test files per issue #773

* Update content extension namespace, identifier-type, and system

* Update namespaces in constraints and unit test data files

* Apply namespace changes to recent constraints and unit test files

* Update src/content/rev5/templates/sap/xml/FedRAMP-SAP-OSCAL-Template.xml

Co-authored-by: A.J. Stein <[email protected]>

* Fix system-identifier, namespace, and system in example content files

* Fix identifier-type and ns in constraints and unit test content files

* Fix namespace references in new constraints

* Fix new constraints

* Fix namespace after rebase

* Use local profile with relative path for #828

Debugging indicates some tests are failing with the `https://` `@href`
for `import-profile` for GitHub "raw" links again.

---------

Co-authored-by: A.J. Stein <[email protected]>
@aj-stein-gsa
Copy link
Contributor Author

The constraints have been deployed and website released. As discussed in the last month of meetings, we notified pilot participants in the group mailing list. I will be marking this as ready to ship.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in FedRAMP Automation Dec 20, 2024
@aj-stein-gsa aj-stein-gsa moved this from ✅ Done to 🚢 Ready to Ship in FedRAMP Automation Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rene2mt Rene2mt

Labels
enhancement New feature or request scope: baselines scope: constraints scope: documentation scope: examples scope: templates
Projects
FedRAMP Automation
Archived in project
Milestone
No milestone
3 participants
@Rene2mt @vmangat @aj-stein-gsa