Update PRA to USWDS 3.0 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 1, 2022
Closed
mejiaj
suggested changes
Sep 1, 2022
There was a problem hiding this comment.
Looks great overall @nick-mon1, just a few minor tweaks and it's ready to go.
I tested:
- Visual check
- New search functions
- Running
updateUswdsandcompiletasks
mejiaj
suggested changes
Sep 6, 2022
There was a problem hiding this comment.
Looks good, just 2 notes
- We need a method of bundling JS — the previous task was removed
- USWDS image directory was gitignored, but we still have images there. For example assets/uswds/img/favicons/favicon.png
mejiaj
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Great work @nick-mon1! Thanks for working through these additional items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uswds2 to 3uswds-gulpwithuswds-compile