Батчи 23-09 #5054

Iajret · 2024-09-23T10:29:42Z

…disk (#86470) ## About The Pull Request Adds an upgrade disk that gives the ability to remotely charge an APC with the AIs backup power (the one that runs down when there is no power in an APC). This tech disk is under advanced AI tech Also added the ability to make new disks with the new object type /obj/item/aiupgrade, and made it so not every AI module is malf, now only subtypes of /datum/ai_module/malf show up on malf upgrade screens ## Why It's Good For The Game Adds the ability for an AI to assist crewmembers who do not have power, which is a pretty interesting interaction. Does chem not have power and is trying to make some healing chems? you can provide power for them for a bit, but they better hurry! ## Changelog :cl: add: Added the remote power AI disk code: made it possible to easily add new AI upgrade disks /:cl: --------- Co-authored-by: Ghom <[email protected]>

## About The Pull Request Adds color back to the lobby crew manifest. Fixes #84768. ## Why It's Good For The Game Adds colour back to the lobby crew manifest, fixing a previous issue. ## Changelog :cl: fix: Lobby crew manifest has colour again /:cl:

## About The Pull Request Added a null check to mood, because it caused runtimes. Nonhumans have mood, but they never initialize it, yet surgery mood assumes it is. Removed unnecessary ishuman check in the organizer, allowing it to work on xenomorphs and other theoretical carbons. ## Why It's Good For The Game > Added a null check to mood, because it caused runtimes. Nonhumans have mood, but they never initialize it, yet surgery mood assumes it is. Bug bad > Removed unnecessary ishuman check in the organizer, allowing it to work on xenomorphs and other theoretical carbons. Oversight bad ## Changelog :cl: fix: Added a null check to mood, because it caused runtimes. Nonhumans have mood, but they never initialize it, yet surgery mood assumes it is. fix: Removed unnecessary ishuman check in the organizer, allowing it to work on xenomorphs and other theoretical carbons. /:cl:

…symbols as your name (#86708) ## About The Pull Request Thanks to Kapu for figuring this one out ## Changelog :cl: SmArtKar, Kapu fix: Agent ID cards no longer display broken text when you put non-letter symbols as your name /:cl:

…(#86691) ## About The Pull Request Some species weren't getting their needed internals when joining ERT. Now they do ![image](https://github.com/user-attachments/assets/200a1397-a32e-43ef-9f75-18c20affde60) ## Why It's Good For The Game Allows other species to safety join ERT ## Changelog :cl: fix: Downstream species not getting internals they need when joining ERT /:cl:

## About The Pull Request - Fixes #86736 ## Changelog :cl: fix: apc breaker properly shuts off all power /:cl:

## About The Pull Request Adds a balloon alert that the expansion has failed, as there previously was confusion on why the blob was attacking space. See #84618 for such an instance. ## Why It's Good For The Game Makes it clear that the blob is not just attacking space for no reason, it is just the expansion failing. ## Changelog :cl: qol: made it clearer that the expansion in space failed for blob instead of wildly flailing at space. /:cl:

… even if they only inserted/removed one (#86734) ## About The Pull Request No idea why we have a replace_tank proc that also removes and adds tanks but atmos code is a fuck. Admins' jobs are hard enough as-is, plus it looks weird for players too ## Changelog :cl: spellcheck: Fixed broken text display in atmos devices in which you can insert a tank admin: Atmos logging no longer lies about everyone swapping tanks in devices even if they only inserted/removed one /:cl:

## About The Pull Request Removes the option of setting a sec flashbang to instant detonation. ## Why It's Good For The Game My reasoning from my previous PR hasn't really changed, so excuse me for the few copypasted bits. Flashbang grenades are one of the best tools in Security arsenal. they are available round-start, widely abundant, and part of the reason why they are so strong is how rare ear protection tends to be. But what tilts the scale from strong to just unfair, in my opinion, is the combination of instant detonation and being able to pierce ear protection entirely on adjacent tiles. This is a hardcoded stun by the way, You could literally have no eyes nor ears and it won't make a difference. I initially considered just reducing the radius at which penetration occurs, but i failed to consider how it would probably result in an unintended buff due to the ability to drag a primed flashbang. So instead, after discussing options with a few other people, including mantainers I think the sanest option is to remove the ability for instant detonation. You can still technically run at someone as a desperate attempt to disarm them, but they'll have a sliver of chance to react. Flashbangs should be used as grenades, not as instant unreactable hardstuns, this strategy requiring teamwork to pull off doesn't justify it being completely unfair and unreactable on the receiver. ## Changelog :cl: balance: Security Flashbangs can no longer be primed for instant detonation. /:cl: --------- Co-authored-by: Xander3359 <[email protected]> Co-authored-by: Time-Green <[email protected]>

…weapons, along with Mounted Gun code. (#86390) ## About The Pull Request ![image](https://github.com/user-attachments/assets/f62c9c17-6886-4170-9e4c-144f9aa1792e) So, as you may know, I really like the bootleg weaponry this game has, but after dealing with gun code for the crossbow, I wasnt inclined to make more of it. However, when I'm playing ss13 I often have background noise on, and one day I was listening to an age of empires game, which, if you aren't aware, is basically a medival rts, featuring a weapon called an "organ gun". Said organ gun is basically 8 or so muskets stuck together firing at once. And well, given SS13 has pipeguns, also called muskets, I couldnt pass up the pun of "pipe organ gun." And thats why this pr exists. However, as I am noticing I have a habit of doing, I tend to end up coding more than I ever initially planned. So what does it add? Well, lets start with the pipe organ gun. <img width="428" alt="image" src="https://github.com/user-attachments/assets/0cb93fb9-6ed3-4cb1-a340-0b54832ac577"> The pipe organ gun is made from wood, pipes, iron, typical maints weapon stuff. Where it differs is it isn't a handheld object - it's a machine you push and pull around akin to say, the pirate cannons. It can hold up to 8 pipegun shells, and launches them all at once when lit with anything that ignites stuff, like a welder, match, torch, etc. It does a lot of damage, but requires time to reload, and a smart enemy can just lie down and ignore it. Or maybe it'll just roll 8 of the really bad ammo types and do nothing, who knows. https://github.com/user-attachments/assets/5ee1353b-c965-4f47-aa22-4f5cfeb04c51 Initially I planned to use the cannon code as a base, but that presented a lot of issues, as they need to use cannonballs (which arent ammo in the traditonal sense), along with only being single shot among other things. So I made an entire new type of structure called Mounted guns, which are like cannons that can use conventional ballistic ammo, and dont have any of the restrictions, and made to be customizable. You want a gun that takes plasma bars as ammo and launches fireballs? it can do that. You want to have a rebar ballista, that can shoot up to 3 rods at once, but only needs to be loaded once? It can do that too. Hell, you could probably just make full-on gun emplacements with some code changes. If it's a projectile, it can shoot it, and if its an object, it can use it as ammo. A list of the current stuff you can change is below. <img width="510" alt="image" src="https://github.com/user-attachments/assets/107abbc1-a004-4724-9627-a3388f92cd63"> Which leads me to the second gun I added, which is more of an example of what can be done with the mounted_gun class. The canister gatling spawns on the flying dutchman pirate ship, with enough ammo for five shots. <img width="453" alt="image" src="https://github.com/user-attachments/assets/46fdc16e-813a-4e14-b25a-9cf49d245ca6"> Five shots may not sound like much at first - but thats because each shot is a burst of 50 individual shrapnel bullets. It's unable to break any walls or doors except for windows, but against anything that isnt a structure... well, as shown below, they'll have a very bad day. https://github.com/user-attachments/assets/3519c49d-97e6-4095-99cf-ee8039adbaba If people like these concepts, I genuinely might add that engineering rebar ballista. ## Why It's Good For The Game As said above, I'm a big fan of the whole improvised armory concept ss13 has, and the fact the only "big" gun featured is the trash cannon (which is locked behind maint loot) is a shame. I felt the pipe-organ gun was a good compromise - as stated, its just eight pipeguns stuck together, with all the strengths (high damage output) and weaknesses (slow reload, needs to be dragged around, cant hit people on the floor, cant damage walls) that it lacks. As for the canister gatling, I dont forsee it being a massive problem, as it cant breach walls or doors, so it isn't just a better cannon. ## Changelog :cl: WebcomicArtist add: Added pipe-organ gun: a buildable object akin to trash cannon that takes pipegun rounds, and shoots up to 8 off at once. add: Added The Canister Gatling, a rapid fire but non-destructive cannon for skeleton pirates. Also Canister shot ammo. sound: Added sounds for the above guns. image: Added sprites for the guns as well. code: Added a whole "mounted_gun" class that is basically cannons but you aren't forced to use cannonballs as ammo and load them with gunpowder. /:cl:

## About The Pull Request Adds a new var called `wound_clothing` to `apply_damage` and `receive_damage` which will be checked in `check_woundings_mods` if it should also apply the damage to the jumpsuit. It's `TRUE` by default. Changes `irradiated` and `body_temperature_damage` to not wound clothing. This also removes the `10 >= damage` check for burns for clothing damage as it was there to prevent freezing from harming clothes which is no longer a problem. ## Why It's Good For The Game Not all brute/burn should also the damage the clothes. This allows for damage to specify if it should damage clothes or not. Radiation burns should not shred my clothes. Code that prevents all damage equal or below ten burn from damaging clothes is BAD, my clothes should BURN. `TRUE` by default so everything else should work normally. fix: #84046 ## Changelog :cl: Goat balance: burn damage equal or under to ten will now damage your jumpsuit (does not apply to internal temp damage) fix: radiation burns no longer damage your jumpsuit. code: added a new var to applying damage to set if it should apply damage to clothes. /:cl: # Conflicts: # code/modules/surgery/bodyparts/_bodyparts.dm

## About The Pull Request tgstation/tgstation#86523 added the yellow border for broken suit sensors on the medical HUD, but I forgot to put the actual text back in the appropriate examine proc after the recent examine box refactor. ![image](https://github.com/user-attachments/assets/b6547d31-ad10-4f69-8880-622041f0cc5b) ## Why It's Good For The Game Less asking 'what does this mean?' because there's a new HUD status but no accompanying information about it. ## Changelog :cl: LT3 fix: Fixed missing examine text for the yellow medical HUD border regarding suit sensors /:cl:

## About The Pull Request setting full_recalc to false would delete the entire field. setting it to true would double what it was meant to be ## Why It's Good For The Game fixes advanced proximity sensors field calculations ## Changelog :cl: /:cl:

… special eyes like Moths) (#86698) ## About The Pull Request ![image](https://github.com/user-attachments/assets/c60a545e-7632-4d1d-9077-e43a2c7b3016) ## Why It's Good For The Game A little bit of added immersion, mainly. Also doesn't mess with people faking death (not ling fake death, *deathgasp shenanigans) because you can literally just wear glasses or turn your body over and people can't see your eyes Also doesn't necessarily *hide* the eyes, so if you examine a dead cultist you'll still see `They have glowing red eyes`. Also yes fakedeath (ling fake death) counts as deceased so your eyes close ## Changelog :cl: Melbert qol: Deceased and asleep humanoids will now close their eyes /:cl:

## About The Pull Request Arlock controller's ID got left out at some point which bricked the entire cycling airlock, fixes that ## Why It's Good For The Game door stuck ## Changelog :cl: fix: Icebox's virology airlock cycles properly again /:cl:

## About The Pull Request fixes museum doors having different door id ## Why It's Good For The Game fuck bugs ## Changelog :cl: fix: doors in museum now work correctly /:cl:

Bumps [actions/stale](https://github.com/actions/stale) from 4 to 9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p> <blockquote> <h2>v9.0.0</h2> <h2>Breaking Changes</h2> <ol> <li>Action is now stateful: If the action ends because of <a href="https://github.com/actions/stale#operations-per-run">operations-per-run</a> then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.</li> <li>Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</li> </ol> <h2>What Else Changed</h2> <ol> <li>Performance optimization that removes unnecessary API calls by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/1033/">#1033</a> fixes <a href="https://redirect.github.com/actions/stale/issues/792">#792</a></li> <li>Logs displaying current github API rate limit by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/1032">#1032</a> addresses <a href="https://redirect.github.com/actions/stale/issues/1029">#1029</a></li> </ol> <p>For more information, please read the <a href="https://github.com/actions/stale#readme">action documentation</a> and its <a href="https://github.com/actions/stale#statefulness">section about statefulness</a></p> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jmeridth"><code>@jmeridth</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/984">actions/stale#984</a></li> <li><a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1020">actions/stale#1020</a></li> <li><a href="https://github.com/dusan-trickovic"><code>@dusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1056">actions/stale#1056</a></li> <li><a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1110">actions/stale#1110</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/stale/compare/v8...v9.0.0">https://github.com/actions/stale/compare/v8...v9.0.0</a></p> <h2>v8.0.0</h2> <p>:warning: This version contains breaking changes :warning:</p> <h2>What's Changed</h2> <ul> <li>New option labels-to-remove-when-stale enables users to specify list of comma delimited labels that will be removed when the issue or PR becomes stale by <a href="https://github.com/panticmilos"><code>@panticmilos</code></a> <a href="https://redirect.github.com/actions/stale/issues/770">actions/stale#770</a></li> <li>Skip deleting the branch in the upstream of a forked repo by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/913">actions/stale#913</a></li> <li>abort the build on the error by <a href="https://github.com/dsame"><code>@dsame</code></a> in <a href="https://redirect.github.com/actions/stale/pull/935">actions/stale#935</a></li> </ul> <h2>Breaking Changes</h2> <ul> <li>In this release we prevent scenarios when the build is not interrupted on some exceptions, which led to successful builds when they are supposed to fail</li> </ul> <h2>Example</h2> <pre lang="yaml"><code>name: 'Remove labels when the issue or PR becomes stale' on: schedule: - cron: '30 1 * * *' <p>permissions: pull-requests: write</p> <p>jobs: stale: runs-on: ubuntu-latest steps: - uses: actions/stale@v8 with: labels-to-remove-when-stale: 'label1,label2' </code></pre></p> <h2>v7.0.0</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/blob/main/CHANGELOG.md">actions/stale's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h1>[7.0.0]</h1> <p>:warning: Breaking change :warning:</p> <ul> <li>Allow daysBeforeStale options to be float by <a href="https://github.com/irega"><code>@irega</code></a> in <a href="https://redirect.github.com/actions/stale/pull/841">actions/stale#841</a></li> <li>Use cache in check-dist.yml by <a href="https://github.com/jongwooo"><code>@jongwooo</code></a> in <a href="https://redirect.github.com/actions/stale/pull/876">actions/stale#876</a></li> <li>fix print outputs step in existing workflows by <a href="https://github.com/irega"><code>@irega</code></a> in <a href="https://redirect.github.com/actions/stale/pull/859">actions/stale#859</a></li> <li>Update issue and PR templates, add/delete workflow files by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/stale/pull/880">actions/stale#880</a></li> <li>Update how stale handles exempt items by <a href="https://github.com/johnsudol"><code>@johnsudol</code></a> in <a href="https://redirect.github.com/actions/stale/pull/874">actions/stale#874</a></li> </ul> <h1>[6.0.1]</h1> <p>Update <code>@actions/core</code> to v1.10.0 (<a href="https://redirect.github.com/actions/stale/pull/839">#839</a>)</p> <h1>[6.0.0]</h1> <p>:warning: Breaking change :warning:</p> <p>Issues/PRs default <code>close-issue-reason</code> is now <code>not_planned</code>(<a href="https://redirect.github.com/actions/stale/issues/789">#789</a>)</p> <h1>[5.1.0]</h1> <p><a href="https://redirect.github.com/actions/stale/issues/696">Don't process stale issues right after they're marked stale</a> [Add close-issue-reason option]<a href="https://redirect.github.com/actions/stale/pull/764">#764</a><a href="https://redirect.github.com/actions/stale/pull/772">#772</a> Various dependabot/dependency updates</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/stale/commit/28ca1036281a5e5922ead5184a1bbf96e5fc984e"><code>28ca103</code></a> Upgrade Node to v20 (<a href="https://redirect.github.com/actions/stale/issues/1110">#1110</a>)</li> <li><a href="https://github.com/actions/stale/commit/b69b346013879cedbf50c69f572cd85439a41936"><code>b69b346</code></a> build(deps-dev): bump <code>@types/node</code> from 18.16.18 to 20.5.1 (<a href="https://redirect.github.com/actions/stale/issues/1079">#1079</a>)</li> <li><a href="https://github.com/actions/stale/commit/88a6f4f6cbe6984b66da80d3d448d5f0c4d1a42d"><code>88a6f4f</code></a> build(deps-dev): bump typescript from 5.1.3 to 5.2.2 (<a href="https://redirect.github.com/actions/stale/issues/1083">#1083</a>)</li> <li><a href="https://github.com/actions/stale/commit/796531a7b39835671cd9f436d7205b1556bbcff6"><code>796531a</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1080">#1080</a> from akv-platform/fix-delete-cache</li> <li><a href="https://github.com/actions/stale/commit/8986f6218b4935e254d5b844e8c36b4d953f2643"><code>8986f62</code></a> Don not try to delete cache if it does not exists</li> <li><a href="https://github.com/actions/stale/commit/cab99b362baa5afbbd8c7c78234e6b071b80687d"><code>cab99b3</code></a> fix typo proceeded/processed</li> <li><a href="https://github.com/actions/stale/commit/184e7afe930f6b5c7ce52c4b3f087692c6e912f3"><code>184e7af</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1064">#1064</a> from actions/dependabot/npm_and_yarn/typescript-esli...</li> <li><a href="https://github.com/actions/stale/commit/523885cf3c115dcdcbed573c7eaf0f5621f124e2"><code>523885c</code></a> chore: update eslint-plugin, parser and eslint-plugin-jest</li> <li><a href="https://github.com/actions/stale/commit/2487a1dc2b501176ca975d2d8b4d3293d72180a2"><code>2487a1d</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code></li> <li><a href="https://github.com/actions/stale/commit/60c722ee97faafece819a7c41b03ec113f99717d"><code>60c722e</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1063">#1063</a> from actions/dependabot/npm_and_yarn/jest-29.6.2</li> <li>Additional commits viewable in <a href="https://github.com/actions/stale/compare/v4...v9">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/stale&package-manager=github_actions&previous-version=4&new-version=9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end)

TGS now does some validation of the access token you give it, which doesn't work well in an actions environment. Just don't give it a token unless absolutely necessary. Private repos can eat shit cause this is AGPL code.

Removed the only instance of `only_forced_audio = TRUE` in /tg/, replaced with `cooldown = (5 SECONDS)`. The variable is still there in case someone needs it. ## About The Pull Request The variable was introduced in tgstation/tgstation#42216 to prevent it from getting annoying. I discussed this change on the forums, previously assuming it was server config https://tgstation13.org/phpBB/viewtopic.php?f=9&t=37131 and people seemed receptive to the idea, spam being the only concern. ## Why It's Good For The Game There are better ways to prevent spam. Extending the cooldown is more favorable than being blocked completely (this is the treatment cyborg *deathgasp received, which is a longer, more jarring sound). Audible emotes help you grab the attention of others (for better or worse). I genuinely find them amusing at times & they remind me of the person on the other side. There is some limit to play-pretend. These emotes enabled some interactions with players I would not have had otherwise. As long as we stop the spam, it breathes some life into a game full of clicking, pointing at people and typing indicators. ## Changelog :cl: del: Intentional screaming has been unmuted. Now has a 5s cooldown instead. /:cl:

## About The Pull Request Closes #52590 ## Changelog :cl: fix: Emergency shuttle console no longer reopens its UI on its own /:cl:

## About The Pull Request Diseases copy their instances, so they should be cleaned up afterwards Closes #86800 ## Changelog :cl: fix: Fixed infective components not cleaning up disease datums after themselves /:cl:

## About The Pull Request Rewrites a good chunk of express console code, removing one letter variables, duplicate code and straightening all the staircases with early returns. RIP cooldowns in ui_data() Mapped-in consoles now actually work, as currently they initialize before SSshuttles which results in them having a completely empty packs menu. This is fixed by making them report themselves to SSshuttles which will call package init on them once it itself initializes. Emagging the console will update the prices in the UI, and emagged consoles will try to send at least 1 package instead of requiring the budget to have enough funds to send all 5 pods. Because when you press a button with a price tag on it, you'd expect at least something to happen. Beacons now reset their offsets when anchored because thats been triggering my OCD. Upgrade disks aren't deleted and instead drop when the console is deconstructed. ## Why It's Good For The Game Code is crunchy, stuff is broken, prices aren't displayed correctly when the console is emagged and you'd expect at least something to arrive when you press a button with a price that you can afford. ## Changelog :cl: fix: Mapped in express supply consoles now work instead of displaying an empty UI. fix: Emagged express supply consoles now display updated prices. refactor: Rewrote a large chunk of express supply console code balance: Express supply consoles now drop their upgrade disk upon being deconstructed, and emagged consoles now will try to send at least one package to the station if cargo budget doesn't have enough funds for all 5. /:cl:

## About The Pull Request #86291 added the option to link fishing spots to the fish portal generator, however I did not sprite radial icons for any of them beside a default undescriptive star just to not leave them icon-less. This PR introduces radial icon states for linkable fishing spots and overlays that show on the fish portal gen when selected. A few actually reuse pre-existing icons, like for example chasms and the beach, but most of them are new. To top it off, linked fishing spots show a little star on the top-left of their radial icon to distinguish them from normal portals. ## Why It's Good For The Game Follow-up to my previous PR where I had gotten too lazy to sprite these icon states. Here's how they look in the editor, which is not much different than how they'd look in-game because the radial buttons are more or less that dark too: ![immagine](https://github.com/user-attachments/assets/e00d80e9-39c6-473c-b791-d83f53bacc6e) ## Changelog :cl: image: added icon states for linkable fishing spots in the fish portal gen radial menu. /:cl:

…ly reduced exp gain from ez pz fishing spots. (#86776) ## About The Pull Request The fishing skill now improves the casting range of the rod by 1 turf at expert level and 2 at legendary level. It also reduces the delay for reeling objects (not the fishing minigame), which by default is 0.8 seconds, up to 0.3 seconds. Reeling objects also provides a pitiable amount of fishing experience. Fishing on fishing spots with particularly low difficulty compared to the overall skill level now reduces the experience gained. Keep in mind fishing also provides a exp bonus based on difficulty regardless of skill level. This just serves to mitigate the bonus from toilets & co at high level. ## Why It's Good For The Game A good angler should know how to spin the rod and cast the line farther than the average person, and reel in objects faster. ## Changelog :cl: balance: The fishing skill now positively affects fishing rod cast range and reeling objects outside of the minigame. Reeling objects also provides a pitiable amount of fishing experience. balance: High fishing skill now reduces experience gained from low difficulty fishing spots. sound: Removed noise from reeling sounds. /:cl:

## About The Pull Request This PR introduces three new fish that can be caught from deep fryers. That's right, deep fryers are also fishing spots now. Is it silly? Yeah, but this is more or less the reason I made a whole PR to make fish edible. They've two gimmicks: one is that they're already fried, and neither raw nor gorey and can be cut into nuggets. The other is that they can evolve into the next type just by growing, no need of pairing them with each other, starting from the 'fryish', then the 'fritterish' (and its two variants: 'bernard-fish' and 'matthew-fish', big pun on the english food company) and finally the 'nessie-fish' which is very rare and big and you'd probably get 20 nuggets by cutting it alone. Other than that, this PR adds a simple growth mechanic to fish, where they get a bit larger each time they're fed. The gained size and weight depends on several factors like hunger, their current size and weight and how much until they hit the maximum cap of twice the initial size and weight. This means bigger fish grow slowier, and it's better to feed them once in a while but not every other second. Obviously size and weight influence a lot of fish mechanics, so it's good to have a way to increase these values outside of breeding RNG (which is very shallow). TL;DR: Feed the fish once their hunger reaches 50% circa for maximum growth. Included in the PR are a few tidbits, like fixing a little mistake around the 'picky eater' fish trait, more readable code around the fish_growth component (unrelated to the aforementioned growth mechanic) and hunger or adding the fish evolution datum for armored pikes (normal pikes plus stinger trait, which I basically forgot to), and adjusting how weight and size of offsprings is calculated. ## Why It's Good For The Game First and foremost, a brand new on-station fishing spot that is not the fishing portal, toilets (or the rare moisture traps in maint). Second, a fish growth mechanic through which weight and size can be increased. Third, a few code things. Four, little bugs, now fixed. Fifth, have a screenshot of me fucking around to find out how many bites it takes to eat all of the deepfried gargantuan nessie (53, and I had to spawn another 10 humans to finish it): ![immagine](https://github.com/user-attachments/assets/a7054cac-6f94-4327-891e-f171894a71d6) ## Changelog :cl: add: You can now fish new, tasty treats by the station deep fryers. add: You can now grow fish inside an aquarium by feeding them regularly (at 50% hunger for maximum growth). add: Added the evolution for pikes to armored pikes. /:cl:

…ort (explode into headslug) is innate (#86605) ## About The Pull Request I've been beating a drum for a little while that Heretic is just Better Changeling, and one of the things that Heretic has that simply blows changeling out of the water is a Get Out of Jail For A Crafted Item card. I took inspiration from that and made the headslug explosion ability for changeling innate. Now they can use it any time they have 20 chemicals. If you want to make sure you're gonna be able to get the ling to the incinerator or a nearby shuttle parking, bait out their abilities, kill them, then set them on fire. Fire stops ling chem regen. Second: Lings aren't really fitting the niche of "Monster That Rapidly Adapts By Consuming Humanoid DNA" very much by being able to readapt once if they've recently killed someone. Instead, I changed it so their readaption is a counter that increments up when they absorb someone. This makes them more adaptable, but it doesn't really increase their strength outside of giving them more ability variety... kinda like Heretic having all their abilities available at all times if they have a focus. I hope this will bring ling more in-line with the other antagonists in the department of Not Sucking in comparison when comparing inherent abilities. ## Why It's Good For The Game Changeling kinda sucks. People have been spamming blood spiders because it is honestly the only viable strategy as a changeling to not get horribly murdered by the valid salad cuisine team extraordinaire. If I'm being totally honest, I'm hoping we can get ling into a place where we can get rid of blood spiders, because I fucking hate how blood spiders work right now, but that's outside the scope of this... This also encourages people to light lings on fire. Fire doesn't prevent headslugging, but if you've managed to outplay the ling into spending all their chemicals before you light their ass up, I think you earned it at that point. Currently, buying headslug is basically trading a power and admitting to yourself "I'm probably gonna fuck up so I'll be less powerful in exchange for this escape route". Instead, just let them explode at their leisure. They already give up every single thing they have on their person when they do this -- ID, weapons, tools, etc -- and they still need to go through the process of finding a corpse to implant in afterward. ## Changelog :cl: Bisar balance: Changelings are now able to respec multiple times if they have absorbed multiple humanoids, instead of it being toggled on if it was off during their most recent absorb. balance: Last Resort is now an innate ability for changelings. code: Added a little counter and a tgui function for displaying how many absorbs lings have in their belly to spend for readaptions! /:cl:

…hacked cigarette vending machines) (#86098) ## About The Pull Request So, do you remember orbies, those cutesy virtual PDA pets from that PR that Ben made roughly six months ago before moving on his next project, leaving them to be probably forgotten in a near future/present/past? Yeah, personally I never played around, however I recalled that they do have customizable virtual hats, which can be selected from a dropdown in the UI, and I thought that it would be a perfect target for some achievement-related content, as they're totally cosmetic that provides no gameplay advantage nor affects balance in no way whatsoever. I cannot sit well with cheevos being purely an end to itself, that's the reason this PR exists. The new additions to orbies hats, and their respective required achievements are: - The fishing hat (Legendary Fisher) - A huge-ass rollie (Unhealthy Snacks) (yeah, it isn't exactly a hat but the code in no way assume that the item has to be a hat, beside vars named like that for the sake of convenience) - A tape wizard hat (Archmage) - An energy cakehat (Very Important Piscis) - A bounty hunter cowboy hat (Hot Damn!) - A fancy crown (Outdebted) The huge-ass rollie (called fat dart) in the game, is a new cigarette, rarely found in hacked cigarette vending machines. It's obviously a reference to that Ralsei meme from 3 years ago or so but I personally don't care, I just wanted to give an excessively big cigarette to orbies to symbolize the proposterous accomplishment of eating 500 cigarettes in a single round without dying from nicotine OD less than halfway through, but since orbie hats use actual items are references for their appearance, I found myself obliged to add one to the code. Overall, the fat dart comes from an old PR on Citadel, though I had to resprite it myself. Here's a lazy collage of the hats. For some reason unbeknownst to me, the hats are horizontally squished. I need to ask Ben why he did them this way when Orbies' heads are as wide as a rugby ball. ![immagine](https://github.com/user-attachments/assets/f1b0e28f-1fb5-4678-bc32-fe38ca04a1b6) ## Why It's Good For The Game Simple, extra cosmetic stuff for a simple feature that's as relevant as playing around with plushes. ## Changelog :cl: add: Added more customizable options to PDA virtual pets, which can be unlocked by completing achievements. add: Added a fat dart that can be rarely found in hacked cigarette vending machines. /:cl:

Vect0r2 and others added 30 commits September 23, 2024 12:56

Automatic changelog for PR #86470 [ci skip]

4977da2

Automatic changelog for PR #86751 [ci skip]

eeb0126

Automatic changelog for PR #86749 [ci skip]

a12c9d5

Automatic changelog for PR #86708 [ci skip]

ef51598

Automatic changelog for PR #86691 [ci skip]

89d0971

APC breaker properly shuts off all power (#86748)

9abf396

## About The Pull Request - Fixes #86736 ## Changelog :cl: fix: apc breaker properly shuts off all power /:cl:

Automatic changelog for PR #86748 [ci skip]

4ba380a

Automatic changelog for PR #86728 [ci skip]

91eef4b

Automatic changelog for PR #86734 [ci skip]

5c11d9f

Automatic changelog for PR #86704 [ci skip]

b87219d

Automatic changelog for PR #86390 [ci skip]

d25cc0a

Automatic changelog for PR #86755 [ci skip]

1a339ef

Automatic changelog for PR #86731 [ci skip]

1de40e5

Automatic changelog for PR #86698 [ci skip]

b726122

Fix icebox's virology airlock (#86743)

b3a1829

## About The Pull Request Arlock controller's ID got left out at some point which bricked the entire cycling airlock, fixes that ## Why It's Good For The Game door stuck ## Changelog :cl: fix: Icebox's virology airlock cycles properly again /:cl:

Automatic changelog for PR #86743 [ci skip]

df98676

Fixes museum doors (#86766)

2bbf8eb

## About The Pull Request fixes museum doors having different door id ## Why It's Good For The Game fuck bugs ## Changelog :cl: fix: doors in museum now work correctly /:cl:

tgstation-ci bot and others added 26 commits September 23, 2024 12:56

Automatic changelog for PR #86821 [ci skip]

116ca64

Fix TGS Test (#86840)

413794e

TGS now does some validation of the access token you give it, which doesn't work well in an actions environment. Just don't give it a token unless absolutely necessary. Private repos can eat shit cause this is AGPL code.

Emergency shuttle console no longer reopens its UI on its own (#86822)

df0edb4

## About The Pull Request Closes #52590 ## Changelog :cl: fix: Emergency shuttle console no longer reopens its UI on its own /:cl:

Replaces QDEL_NULL with QDEL_LIST in infective component (#86812)

47f7808

## About The Pull Request Diseases copy their instances, so they should be cleaned up afterwards Closes #86800 ## Changelog :cl: fix: Fixed infective components not cleaning up disease datums after themselves /:cl:

Automatic changelog for PR #86782 [ci skip]

130a7c5

Automatic changelog for PR #86822 [ci skip]

6c56941

Automatic changelog for PR #86812 [ci skip]

9ef0871

Automatic changelog for PR #86634 [ci skip]

7c4d84b

Automatic changelog for PR #86774 [ci skip]

5ddaff6

Automatic changelog for PR #86776 [ci skip]

3385c1e

Automatic changelog for PR #86690 [ci skip]

55b599b

Automatic changelog for PR #86605 [ci skip]

491ec36

Automatic changelog for PR #86098 [ci skip]

6c8bebb

Early fix for accounts

2f0733a

github-actions bot added Sprites Map Modification labels Sep 23, 2024

Iajret merged commit f092bdf into master Sep 23, 2024
31 checks passed

Iajret deleted the more-batches branch September 23, 2024 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Батчи 23-09 #5054

Батчи 23-09 #5054

Iajret commented Sep 23, 2024

Батчи 23-09 #5054

Батчи 23-09 #5054

Conversation

Iajret commented Sep 23, 2024