Батчи 23-09 #5054

Батчи 23-09
Fluffy-Frontier · Sep 23, 2024 · f092bdf · f092bdf
2 parents 0c418f4 + 2f0733a
commit f092bdf
Show file tree

Hide file tree

Showing 323 changed files with 3,613 additions and 2,200 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -0,0 +1,11 @@
+# https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
+version: 2
+updates:
+  - package-ecosystem: github-actions
+    directory: /
+    target-branch: master
+    schedule:
+      interval: daily
+    labels:
+      - GitHub
+    open-pull-requests-limit: 10
diff --git a/.github/guides/STANDARDS.md b/.github/guides/STANDARDS.md
@@ -513,6 +513,30 @@ The following is a list of procs, and their safe replacements.
 * Move away from something, taking turf density into account `walk_away()` -> `SSmove_manager.move_away()`
 * Move to a random place nearby. NOT random walk `walk_rand()` -> `SSmove_manager.move_rand()` is random walk, `SSmove_manager.move_to_rand()` is walk to a random place
 
+### Avoid pointer use
+
+BYOND has a variable type called pointers, which allow you to reference a variable rather then its value. As an example of how this works:
+
+```
+var/pointed_at = "text"
+var/value = pointed_at // copies the VALUE of pointed at
+var/reference = &pointed_at // points at pointed_at itself
+
+// so we can retain a reference even if pointed_at changes
+pointed_at = "text AGAIN"
+world << (*reference) // Deref to get the value, outputs "text AGAIN"
+
+// or modify the var remotely
+*reference = "text a THIRD TIME"
+world << pointed_at // outputs "text a THIRD TIME"
+```
+
+The problem with this is twofold.
+- First: if you use a pointer to reference a var on a datum, it is essentially as if you held an invisible reference to that datum. This risks hard deletes in very unclear ways that cannot be tested for.
+- Second: People don't like, understand how pointers work? They mix them up with classical C pointers, when they're more like `std::shared_ptr`. This leads to code that just doesn't work properly, or is hard to follow without first getting your mind around it. It also risks hiding what code does in dumb ways because pointers don't have unique types.
+
+For these reasons and with the hope of avoiding pointers entering general use, be very careful using them, if you use them at all.
+
 ### BYOND hellspawn
 
 What follows is documentation of inconsistent or strange behavior found in our engine, BYOND.

diff --git a/.github/workflows/auto_changelog.yml b/.github/workflows/auto_changelog.yml
@@ -28,7 +28,7 @@ jobs:
         APP_ID: ${{ secrets.APP_ID }}
 
     - name: Run auto changelog
-      uses: actions/github-script@v6
+      uses: actions/github-script@v7
       with:
         script: |
           const { processAutoChangelog } = await import('${{ github.workspace }}/tools/pull_request_hooks/autoChangelog.js')

diff --git a/.github/workflows/ci_suite.yml b/.github/workflows/ci_suite.yml
@@ -76,7 +76,7 @@ jobs:
           path: tools/icon_cutter/cache
           key: ${{ runner.os }}-cutter-${{ hashFiles('dependencies.sh') }}
       - name: Install OpenDream
-        uses: robinraju/release-downloader@v1.9
+        uses: robinraju/release-downloader@v1.11
         with:
           repository: "OpenDreamProject/OpenDream"
           tag: "latest"

diff --git a/.github/workflows/compile_changelogs.yml b/.github/workflows/compile_changelogs.yml
@@ -23,7 +23,7 @@ jobs:
 
       - name: "Setup python"
         if: steps.value_holder.outputs.ACTIONS_ENABLED
-        uses: actions/setup-python@v1
+        uses: actions/setup-python@v5
         with:
           python-version: '3.x'
 

diff --git a/.github/workflows/generate_documentation.yml b/.github/workflows/generate_documentation.yml
@@ -27,10 +27,9 @@ jobs:
           touch dmdoc/.nojekyll
           echo codedocs.tgstation13.org > dmdoc/CNAME
       - name: Deploy
-        uses: JamesIves/github-pages-deploy-action@3.7.1
+        uses: JamesIves/github-pages-deploy-action@v4.6.4
         with:
-          BRANCH: gh-pages
-          CLEAN: true
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SINGLE_COMMIT: true
-          FOLDER: dmdoc
+          branch: gh-pages
+          clean: true
+          single-commit: true
+          folder: dmdoc
diff --git a/.github/workflows/remove_guide_comments.yml b/.github/workflows/remove_guide_comments.yml
@@ -11,7 +11,7 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
     - name: Remove guide comments
-      uses: actions/github-script@v6
+      uses: actions/github-script@v7
       with:
         script: |
           const { removeGuideComments } = await import('${{ github.workspace }}/tools/pull_request_hooks/removeGuideComments.js')

diff --git a/.github/workflows/rerun_flaky_tests.yml b/.github/workflows/rerun_flaky_tests.yml
@@ -12,7 +12,7 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
     - name: Rerun flaky tests
-      uses: actions/github-script@v6
+      uses: actions/github-script@v7
       with:
         script: |
           const { rerunFlakyTests } = await import('${{ github.workspace }}/tools/pull_request_hooks/rerunFlakyTests.js')
@@ -24,7 +24,7 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
     - name: Report flaky tests
-      uses: actions/github-script@v6
+      uses: actions/github-script@v7
       with:
         script: |
           const { reportFlakyTests } = await import('${{ github.workspace }}/tools/pull_request_hooks/rerunFlakyTests.js')

diff --git a/.github/workflows/show_screenshot_test_results.yml b/.github/workflows/show_screenshot_test_results.yml
@@ -34,7 +34,7 @@ jobs:
           npm install node-fetch
       - name: Show screenshot test results
         if: steps.secrets_set.outputs.SECRETS_ENABLED
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         env:
           FILE_HOUSE_KEY: ${{ secrets.ARTIFACTS_FILE_HOUSE_KEY }}
         with:

diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-    - uses: actions/stale@v4
+    - uses: actions/stale@v9
       with:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
         stale-pr-message: "This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself."

diff --git a/.github/workflows/test_merge_bot.yml b/.github/workflows/test_merge_bot.yml
@@ -32,7 +32,7 @@ jobs:
             npm install node-fetch
         - name: Check for test merges
           if: steps.secrets_set.outputs.GET_TEST_MERGES_URL
-          uses: actions/github-script@v6
+          uses: actions/github-script@v7
           env:
             GET_TEST_MERGES_URL: ${{ secrets.GET_TEST_MERGES_URL }}
           with:

diff --git a/.github/workflows/tgs_test.yml b/.github/workflows/tgs_test.yml
@@ -57,7 +57,7 @@ jobs:
           - 5000:5000 #Can't use env here for some reason
     steps:
       - name: Setup dotnet
-        uses: actions/setup-dotnet@v2
+        uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 8.0.x
 

diff --git a/_maps/RandomZLevels/museum.dmm b/_maps/RandomZLevels/museum.dmm
@@ -2720,7 +2720,7 @@
 "wi" = (
 /obj/machinery/door/poddoor/shutters/indestructible{
 	dir = 8;
-	id = "museum_secret"
+	id = "museum_right_wing"
 	},
 /turf/open/floor/iron,
 /area/awaymission/museum)
@@ -3958,7 +3958,7 @@
 /area/awaymission/museum)
 "FO" = (
 /obj/effect/decal/cleanable/crayon/puzzle/pin{
-	puzzle_id = "museum_r_wing_puzzle"
+	puzzle_id = "museum_right_wing"
 	},
 /turf/closed/indestructible/reinforced,
 /area/awaymission/museum)
@@ -4152,7 +4152,7 @@
 /obj/effect/turf_decal/siding/dark_blue,
 /obj/machinery/door/poddoor/shutters/indestructible{
 	dir = 8;
-	id = "museum_secret"
+	id = "museum_right_wing"
 	},
 /turf/open/floor/iron/dark,
 /area/awaymission/museum)
@@ -4221,7 +4221,7 @@
 /area/awaymission/museum)
 "Id" = (
 /obj/effect/decal/cleanable/crayon/puzzle/pin{
-	puzzle_id = "museum_r_wing_puzzle"
+	puzzle_id = "museum_right_wing"
 	},
 /turf/closed/indestructible/wood,
 /area/awaymission/museum)
@@ -5246,7 +5246,7 @@
 /obj/structure/fluff/fake_camera,
 /obj/effect/decal/puzzle_dots{
 	pixel_y = -32;
-	id = "museum_r_wing_puzzle"
+	id = "museum_right_wing"
 	},
 /turf/open/floor/iron/dark,
 /area/awaymission/museum)
@@ -5332,10 +5332,10 @@
 	},
 /obj/machinery/door/poddoor/shutters/indestructible{
 	dir = 8;
-	id = "museum_secret"
+	id = "museum_right_wing"
 	},
 /obj/machinery/puzzle/password/pin/directional/south{
-	id = "museum_r_wing_puzzle";
+	id = "museum_right_wing";
 	late_initialize_pop = 1
 	},
 /turf/open/floor/iron/dark,
@@ -5349,7 +5349,7 @@
 /obj/machinery/light/directional/west,
 /obj/effect/decal/cleanable/crayon/puzzle/pin{
 	pixel_x = -32;
-	puzzle_id = "museum_r_wing_puzzle"
+	puzzle_id = "museum_right_wing"
 	},
 /turf/open/floor/iron/white/small,
 /area/awaymission/museum)