[MIRROR] Buying the advanced plastic surgery disk now gives you the right disk #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight disk (#1226) * Buying the advanced plastic surgery disk now gives you the right disk (#81746) ## About The Pull Request Buying the advanced plastic surgery disk currently gives you a brainwashing disk instead, this fixes that. ## Why It's Good For The Game big oversight, you now get the right program you bought. ## Changelog :cl: fix: Buying the advanced plastic surgery disk from the uplink now gives you advanced plastic surgery instead of brainwashing. /:cl: * Buying the advanced plastic surgery disk now gives you the right disk --------- Co-authored-by: John Willard <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 2, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 28, 2024
) * Removes examine text with Med/Sec HUDs being under Radio (#82899) ## About The Pull Request As title says One of these spans didn't have a closing span so this fixes that too i guess. These are all spans that would include your message under radio ``'.alert, .minorannounce, .syndradio, .centcomradio, .aiprivradio, .comradio, .secradio, .gangradio, .engradio, .medradio, .sciradio, .suppradio, .servradio, .radio, .deptradio, .binarysay, .newscaster, .resonate, .abductor, .alien, .changeling'`` To fix it I just removed the span since it did nothing anyway. I didn't remove it in case it's ever brought back in the future and for any downstream that might use it, it feels off to remove chat constants. It also looks no different either way  tried with multiple fonts, this really has no effect it's purely for categorization. ## Why It's Good For The Game Closes tgstation/tgstation#72487 ## Changelog :cl: fix: Examining someone with Med/Sec HUDs will no longer filter the message under Radio. /:cl: * Removes examine text with Med/Sec HUDs being under Radio --------- Co-authored-by: John Willard <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 29, 2024
) (#3092) * Removes examine text with Med/Sec HUDs being under Radio (#82899) ## About The Pull Request As title says One of these spans didn't have a closing span so this fixes that too i guess. These are all spans that would include your message under radio ``'.alert, .minorannounce, .syndradio, .centcomradio, .aiprivradio, .comradio, .secradio, .gangradio, .engradio, .medradio, .sciradio, .suppradio, .servradio, .radio, .deptradio, .binarysay, .newscaster, .resonate, .abductor, .alien, .changeling'`` To fix it I just removed the span since it did nothing anyway. I didn't remove it in case it's ever brought back in the future and for any downstream that might use it, it feels off to remove chat constants. It also looks no different either way  tried with multiple fonts, this really has no effect it's purely for categorization. ## Why It's Good For The Game Closes tgstation/tgstation#72487 ## Changelog :cl: fix: Examining someone with Med/Sec HUDs will no longer filter the message under Radio. /:cl: * Removes examine text with Med/Sec HUDs being under Radio --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1226
Original PR: tgstation/tgstation#81746
About The Pull Request
Buying the advanced plastic surgery disk currently gives you a brainwashing disk instead, this fixes that.
Why It's Good For The Game
big oversight, you now get the right program you bought.
Changelog
🆑 JohnFulpWillard
fix: Buying the advanced plastic surgery disk from the uplink now gives you advanced plastic surgery instead of brainwashing.
/:cl: