Skip to content

Commit

Permalink
[MIRROR] Removes examine text with Med/Sec HUDs being under Radio (#2214
Browse files Browse the repository at this point in the history
) (#3092)

* Removes examine text with Med/Sec HUDs being under Radio (#82899)

## About The Pull Request

As title says
One of these spans didn't have a closing span so this fixes that too i
guess.

These are all spans that would include your message under radio
``'.alert, .minorannounce, .syndradio, .centcomradio, .aiprivradio,
.comradio, .secradio, .gangradio, .engradio, .medradio, .sciradio,
.suppradio, .servradio, .radio, .deptradio, .binarysay, .newscaster,
.resonate, .abductor, .alien, .changeling'``

To fix it I just removed the span since it did nothing anyway.
I didn't remove it in case it's ever brought back in the future and for
any downstream that might use it, it feels off to remove chat constants.

It also looks no different either way

![image](https://github.com/tgstation/tgstation/assets/53777086/46673645-4ab4-4bd2-9a9f-a26b19aa0e87)

tried with multiple fonts, this really has no effect it's purely for
categorization.

## Why It's Good For The Game

Closes tgstation/tgstation#72487

## Changelog

:cl:
fix: Examining someone with Med/Sec HUDs will no longer filter the
message under Radio.
/:cl:

* Removes examine text with Med/Sec HUDs being under Radio

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: John Willard <[email protected]>
  • Loading branch information
3 people authored Apr 29, 2024
1 parent 7b5a5ae commit c11246a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions code/modules/mob/living/carbon/human/examine.dm
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@
if(perpname && (HAS_TRAIT(user, TRAIT_SECURITY_HUD) || HAS_TRAIT(user, TRAIT_MEDICAL_HUD)))
var/datum/record/crew/target_record = find_record(perpname)
if(target_record)
. += "<span class='deptradio'>Rank:</span> [target_record.rank]\n<a href='?src=[REF(src)];hud=1;photo_front=1;examine_time=[world.time]'>\[Front photo\]</a><a href='?src=[REF(src)];hud=1;photo_side=1;examine_time=[world.time]'>\[Side photo\]</a>"
. += "Rank: [target_record.rank]\n<a href='?src=[REF(src)];hud=1;photo_front=1;examine_time=[world.time]'>\[Front photo\]</a><a href='?src=[REF(src)];hud=1;photo_side=1;examine_time=[world.time]'>\[Side photo\]</a>"
if(HAS_TRAIT(user, TRAIT_MEDICAL_HUD))
var/cyberimp_detect
for(var/obj/item/organ/internal/cyberimp/cyberimp in organs)
Expand Down Expand Up @@ -439,11 +439,11 @@
if(target_record.security_note)
security_note = target_record.security_note
if(ishuman(user))
. += "<span class='deptradio'>Criminal status:</span> <a href='?src=[REF(src)];hud=s;status=1;examine_time=[world.time]'>\[[wanted_status]\]</a>"
. += "Criminal status: <a href='?src=[REF(src)];hud=s;status=1;examine_time=[world.time]'>\[[wanted_status]\]</a>"
else
. += "<span class='deptradio'>Criminal status:</span> [wanted_status]"
. += "<span class='deptradio'>Important Notes: [security_note]"
. += "<span class='deptradio'>Security record:</span> <a href='?src=[REF(src)];hud=s;view=1;examine_time=[world.time]'>\[View\]</a>"
. += "Criminal status: [wanted_status]"
. += "Important Notes: [security_note]"
. += "Security record: <a href='?src=[REF(src)];hud=s;view=1;examine_time=[world.time]'>\[View\]</a>"
if(ishuman(user))
. += jointext(list("<a href='?src=[REF(src)];hud=s;add_citation=1;examine_time=[world.time]'>\[Add citation\]</a>",
"<a href='?src=[REF(src)];hud=s;add_crime=1;examine_time=[world.time]'>\[Add crime\]</a>",
Expand Down

0 comments on commit c11246a

Please sign in to comment.