[MIRROR] Fixes oversight with DROP_BRAIN #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes oversight with DROP_BRAIN * Update death.dm --------- Co-authored-by: Bloop <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-1215
AnywayFarus
added a commit
that referenced
this pull request
Mar 1, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 27, 2024
* fixes jps mobs occasioanlly pathing forever (#82874) ## About The Pull Request if MOVELOOP_NOT_READY gets passed once through the signal (which can be often), the failure increments gets reset back to 0 and starts counting again. this can cause the increments to never reach the max failure threshold so itll keep checking forever. i saw some mobs get stuck trying to reach an unreachable target because of this ## Why It's Good For The Game fixes mobs getting stuck trying to reach something unreachable ## Changelog :cl: fix: fixes mobs getting stuck trying to reach something unreachable /:cl: * fixes jps mobs occasioanlly pathing forever --------- Co-authored-by: Ben10Omintrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1215
Original PR: tgstation/tgstation#81735
About The Pull Request
Brains might not always be located in the head, e.g. HARS puts it in the chest, thus making the assumption that the brain will always be in the head in this conditional false.
Also fixes this compiler warning
Why It's Good For The Game
Fixes a bug/oversight of a niche edge case.
Changelog
🆑 vinylspiders
fix: fixes an issue where being gibbed while under the HARS mutation can sometimes lead to the brain being deleted when it's not supposed to be
/:cl: