[MIRROR] Fixes bows not loosening their strings once fired #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes bows not loosening their strings once fired (#81724) ## About The Pull Request So, there's this one place that could have just called `clear_chambered` because it does the exact same operations, but didn't. Here's `gun/ballistic/proc/clear_chambered()`: https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic.dm#L285-L288 and here's `gun/ballistic/bow/clear_chambered()`, which is responsible for setting `drawn` to false: https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic/bows/_bow.dm#L52-L54 You can connect the dots. * Fixes bows not loosening their strings once fired --------- Co-authored-by: Ghom <[email protected]>
…into upstream-mirror-1208
AnywayFarus
added a commit
that referenced
this pull request
Mar 1, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1208
Original PR: tgstation/tgstation#81724
About The Pull Request
So, there's this one place that could have just called
clear_chamberedbecause it does the exact same operations, but didn't.Here's
gun/ballistic/proc/clear_chambered():https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic.dm#L285-L288
and here's
gun/ballistic/bow/clear_chambered(), which is responsible for settingdrawnto false:https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic/bows/_bow.dm#L52-L54
You can connect the dots.
Why It's Good For The Game
This will fix #81462.
Changelog
🆑 Ghommie
fix: Fixed (cross)bows' strings not loosening once fired.
/:cl: