Skip to content

Commit

Permalink
[MIRROR] Fixes bows not loosening their strings once fired (#2197)
Browse files Browse the repository at this point in the history
* Fixes bows not loosening their strings once fired (#81724)

## About The Pull Request
So, there's this one place that could have just called `clear_chambered`
because it does the exact same operations, but didn't.

Here's `gun/ballistic/proc/clear_chambered()`:

https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic.dm#L285-L288

and here's `gun/ballistic/bow/clear_chambered()`, which is responsible
for setting `drawn` to false:

https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic/bows/_bow.dm#L52-L54

You can connect the dots.

* Fixes bows not loosening their strings once fired

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Ghom <[email protected]>
Co-authored-by: Iajret <[email protected]>
  • Loading branch information
4 people authored Mar 1, 2024
1 parent f880235 commit 16cd9e7
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions code/modules/projectiles/guns/ballistic.dm
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,7 @@
casing.bounce_away(TRUE)
SEND_SIGNAL(casing, COMSIG_CASING_EJECTED)
else if(empty_chamber)
UnregisterSignal(chambered, COMSIG_MOVABLE_MOVED)
chambered = null
clear_chambered()
if (chamber_next_round && (magazine?.max_ammo > 1))
chamber_round()

Expand Down

0 comments on commit 16cd9e7

Please sign in to comment.