[MIRROR] Adds missing gas senders to the North Star #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds missing gas senders to the North Star (#81652) ## About The Pull Request Adds a sender to the atmos project room, and bluespace gas vendors to each floor in the main halls + a bonus one in the SM room. ## Why It's Good For The Game Fixes: #80988 ## Changelog :cl: fix: The North Star finally has a bluespace gas sender system. /:cl: * Adds missing gas senders to the North Star --------- Co-authored-by: Cheshify <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Fixes Alien Numerical Identifier Transfer System (#82762) ## About The Pull Request Fixes #82756 I'm not sure what the root cause of the issue is or why it broke so recently (this has been a thing since #49150) but I went and cleaned up the code and ensured that we always reset the `name` to the `initial()` value we have for it if we determine that we need to transfer over the `numba` from the old xenomorph. This is done by a new proc which is a lot less convoluted from the old system (always respecting var-edited names and stuff like that) that should make it flow a lot better and make it more hardy against double-addition of the `numba` to the name. ## Why It's Good For The Game Having two numbers in your name is weird, should only have one. [x] I tested this PR ## Changelog :cl: fix: Evolved aliens should no longer have two numbers in their name. /:cl: * Fixes Alien Numerical Identifier Transfer System --------- Co-authored-by: san7890 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 22, 2024
) * Fixes Alien Numerical Identifier Transfer System (#82762) ## About The Pull Request Fixes #82756 I'm not sure what the root cause of the issue is or why it broke so recently (this has been a thing since #49150) but I went and cleaned up the code and ensured that we always reset the `name` to the `initial()` value we have for it if we determine that we need to transfer over the `numba` from the old xenomorph. This is done by a new proc which is a lot less convoluted from the old system (always respecting var-edited names and stuff like that) that should make it flow a lot better and make it more hardy against double-addition of the `numba` to the name. ## Why It's Good For The Game Having two numbers in your name is weird, should only have one. [x] I tested this PR ## Changelog :cl: fix: Evolved aliens should no longer have two numbers in their name. /:cl: * Fixes Alien Numerical Identifier Transfer System --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: san7890 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1135
Original PR: tgstation/tgstation#81652
About The Pull Request
Adds a sender to the atmos project room, and bluespace gas vendors to each floor in the main halls + a bonus one in the SM room.
Why It's Good For The Game
Fixes: #80988
Changelog
🆑 Cheshify
fix: The North Star finally has a bluespace gas sender system.
/:cl: