Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) #1875

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[MIRROR] Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion code/__DEFINES/dcs/signals/signals_object.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,10 @@
#define COMSIG_ITEM_PICKUP "item_pickup"
///from base of obj/item/on_outfit_equip(): (mob/equipper, visuals_only, slot)
#define COMSIG_ITEM_EQUIPPED_AS_OUTFIT "item_equip_as_outfit"
///from base of datum/storage/attempt_insert(): ()
///from base of datum/storage/handle_enter(): (datum/storage/storage)
#define COMSIG_ITEM_STORED "item_stored"
///from base of datum/storage/handle_exit(): (datum/storage/storage)
#define COMSIG_ITEM_UNSTORED "item_unstored"

///from base of obj/item/apply_fantasy_bonuses(): (bonus)
#define COMSIG_ITEM_APPLY_FANTASY_BONUSES "item_apply_fantasy_bonuses"
Expand Down
10 changes: 0 additions & 10 deletions code/__HELPERS/atoms.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,6 @@ rough example of the "cone" made by the 3 dirs checked
/proc/pass(...)
return

///Returns a list of the parents of all storage components that contain the target item
/proc/get_storage_locs(obj/item/target)
. = list()
if(!istype(target) || !(target.item_flags & IN_STORAGE))
return
var/datum/storage/storage_datum = target.loc.atom_storage
if(!storage_datum)
return
. += storage_datum.real_location?.resolve()

/// Returns an x and y value require to reverse the transformations made to center an oversized icon
/atom/proc/get_oversized_icon_offsets()
if (pixel_x == 0 && pixel_y == 0)
Expand Down
Loading
Loading