[MIRROR] Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with just refs (because they were managed already) (#785) * Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) * CI fix * Clean up modular items * Surgery Tray Fix --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 9, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 9, 2024
* ds2-qol * small change * windoors in botany... why didn't they have these already? --------- Co-authored-by: NotDhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#785
Original PR: tgstation/tgstation#81120
About The Pull Request
Large amount of storage datum cleanup.
Some bugfixes.
Why It's Good For The Game
Aiming to make storage easier to work with. The whole intent of this was to bugfix the whole "weight class" thing that keeps popping up but I had to do this first.
Changelog
🆑 Melbert
fix: When placing an item into storage (such as backpacks), all nearby mobs now get a message, rather than just the first mob.
fix: TGC decks of cards should act a bit less odd when looking inside.
refactor: Refactored a bit of storage, cleaned up a fair bit of its code. Let me know if you notice anything funky about storage (like backpacks).
/:cl: