-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: create factory methods for "core" terminology service #2548
Merged
ewoutkramer
merged 4 commits into
develop
from
feature/2519-create-terminology-service-factory
Jul 24, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1b4de64
feature: create factory methods for "core" terminology service
mmsmits 60a222e
Merge branch 'develop' into feature/2519-create-terminology-service-f…
mmsmits 8a55804
added unit tests
mmsmits 5fca132
made mimetype valueset constants public
mmsmits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
src/Hl7.Fhir.Conformance/Specification/Terminology/TerminologyServiceFactory.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#nullable enable | ||
|
||
using Hl7.Fhir.Specification.Source; | ||
|
||
namespace Hl7.Fhir.Specification.Terminology | ||
{ | ||
public static class TerminologyServiceFactory | ||
{ | ||
/// <summary> | ||
/// Creates a MultiTerminologyService, which combines a LocalTerminologyService to retrieve the core FHIR resources with custom services to validate some implicit core ValueSets. | ||
/// </summary> | ||
/// <param name="coreResourceResolver">Resource resolves to resolve FHIR core artifacts</param> | ||
/// <param name="expanderSettings">ValueSet expansion settings</param> | ||
/// <returns>A MultiTerminologyService, which combines a LocalTerminologyService to retrieve the core FHIR resources with custom services to validate some implicit core ValueSets</returns> | ||
public static MultiTerminologyService CreateDefaultForCore(IAsyncResourceResolver coreResourceResolver, ValueSetExpanderSettings? expanderSettings = null) | ||
{ | ||
var mimeTypeRoutingSettings = new TerminologyServiceRoutingSettings(new MimeTypeTerminologyService()) | ||
{ | ||
PreferredValueSets = new string[] | ||
{ | ||
"http://hl7.org/fhir/ValueSet/mimetypes" | ||
} | ||
}; | ||
|
||
var localTermRoutingSettings = new TerminologyServiceRoutingSettings(new LocalTerminologyService(coreResourceResolver, expanderSettings)) | ||
{ | ||
PreferredValueSets = new string[] | ||
{ | ||
"http://hl7.org/fhir/ValueSet/" | ||
} | ||
}; | ||
|
||
return new MultiTerminologyService(mimeTypeRoutingSettings, localTermRoutingSettings); | ||
} | ||
|
||
} | ||
} | ||
|
||
#nullable restore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
src/Hl7.Fhir.STU3/Specification/Terminology/TerminologyServiceFactory.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#nullable enable | ||
|
||
using Hl7.Fhir.Specification.Source; | ||
|
||
namespace Hl7.Fhir.Specification.Terminology | ||
{ | ||
public static class TerminologyServiceFactory | ||
{ | ||
/// <summary> | ||
/// Creates a MultiTerminologyService, which combines a LocalTerminologyService to retrieve the core FHIR resources with custom services to validate some implicit core ValueSets. | ||
/// </summary> | ||
/// <param name="coreResourceResolver">Resource resolves to resolve FHIR core artifacts</param> | ||
/// <param name="expanderSettings">ValueSet expansion settings</param> | ||
/// <returns>A MultiTerminologyService, which combines a LocalTerminologyService to retrieve the core FHIR resources with custom services to validate some implicit core ValueSets</returns> | ||
public static MultiTerminologyService CreateDefaultForCore(IAsyncResourceResolver coreResourceResolver, ValueSetExpanderSettings? expanderSettings = null) | ||
{ | ||
var mimeTypeRoutingSettings = new TerminologyServiceRoutingSettings(new MimeTypeTerminologyService()) | ||
{ | ||
PreferredValueSets = new string[] | ||
{ | ||
"http://www.rfc-editor.org/bcp/bcp13.txt" | ||
} | ||
}; | ||
|
||
var localTermRoutingSettings = new TerminologyServiceRoutingSettings(new LocalTerminologyService(coreResourceResolver, expanderSettings)) | ||
{ | ||
PreferredValueSets = new string[] | ||
{ | ||
"http://hl7.org/fhir/ValueSet/" | ||
} | ||
}; | ||
|
||
return new MultiTerminologyService(mimeTypeRoutingSettings, localTermRoutingSettings); | ||
} | ||
|
||
} | ||
} | ||
|
||
#nullable restore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have this as a constant on MimeTypeTerminologyService.