Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: create factory methods for "core" terminology service #2548

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented Jul 21, 2023

fixes: #2519

@mmsmits mmsmits requested a review from ewoutkramer July 21, 2023 11:38
{
PreferredValueSets = new string[]
{
"http://hl7.org/fhir/ValueSet/mimetypes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have this as a constant on MimeTypeTerminologyService.

@mmsmits mmsmits requested a review from ewoutkramer July 24, 2023 12:14
@ewoutkramer ewoutkramer merged commit 606f648 into develop Jul 24, 2023
13 checks passed
@ewoutkramer ewoutkramer deleted the feature/2519-create-terminology-service-factory branch July 24, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design factory methods for Terminology Services
2 participants