Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Borg #420
base: master
Are you sure you want to change the base?
Security Borg #420
Changes from 26 commits
e54fb22
dbfdb83
e5d52b8
3d875f6
158faf2
7e2dd64
011a207
1c393df
4165083
032291f
06fda0c
59bd1a1
adb4986
738e6c4
e5e95be
e7733a7
6a44521
cdbd033
6fbc19e
6fefa71
e791f90
54e2530
6bf9a6d
cbe5064
d28728b
4e357d0
170b3c3
919f248
b671a19
ba95ee3
69b62a8
524f022
5ccb1ee
69f1b76
a769672
5a38f00
24f65cf
6260d8a
364d852
cad3506
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion but you should add IntrinsicRadioTransmitter and ActiveRadio comp so the borg can speak also in security channels.
I suggest those channels: Binary, Common, Security, Science
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, I think until we get these buildable having them start with security channel might be iffy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You gave them AccessReader with security access, this borg is a security chassie correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but until they are actually something that may be assembled I think the channel keys should be something put in manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Cyborg is missing/using duplicated sprite for mind state, while this is not an issue right now, when its is public this will need to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uneeded and this will cause issues with the current cyborg build, Speechverb is already on parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I literally had to add this back because it threw errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, strange, il look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehh this inst normal, did you remove something by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I moved an unused sprite into my rsi so it can be used. Because you said to. The image and the module itself both need to be in the rsi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehh this inst normal, did you remove something by mistake?