Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Borg #420

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Security Borg #420

wants to merge 39 commits into from

Conversation

fenndragon
Copy link
Contributor

Description

this PR adds Quadborg Security bots to the game as an entity (they have no construction setup or parts built in so it's exclusively an admin only spawn for now, but it also adds a few modules specific to security borgs.

Changelog

🆑

  • add: Added Security Quadborg

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

RSI Diff Bot; head commit 364d852 merging into 55d7352
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Mobs/Silicon/quad.rsi

State Old New Status
quadsprite Added
quadspritel Added
quadspriter Added

Resources/Textures/Floof/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-Advmeasures Added
icon-capture Added
icon-explosive Added
icon-investigation Added
icon-kill Added
icon-stun Added

Edit: diff updated after 364d852

@FoxxoTrystan FoxxoTrystan added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Dec 19, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this need to be changed to the floor directory.

Comment on lines 35 to 38
- type: Construction
node: cyborg
- type: Speech
speechVerb: Robotic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: Construction
node: cyborg
- type: Speech
speechVerb: Robotic

Uneeded and this will cause issues with the current cyborg build, Speechverb is already on parent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I literally had to add this back because it threw errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, strange, il look into it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion but you should add IntrinsicRadioTransmitter and ActiveRadio comp so the borg can speak also in security channels.

I suggest those channels: Binary, Common, Security, Science

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I think until we get these buildable having them start with security channel might be iffy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gave them AccessReader with security access, this borg is a security chassie correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but until they are actually something that may be assembled I think the channel keys should be something put in manually

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Cyborg is missing/using duplicated sprite for mind state, while this is not an issue right now, when its is public this will need to be changed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh this inst normal, did you remove something by mistake?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh this inst normal, did you remove something by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I moved an unused sprite into my rsi so it can be used. Because you said to. The image and the module itself both need to be in the rsi

@VividPups
Copy link
Contributor

hey i had a security borg made

@FoxxoTrystan FoxxoTrystan self-requested a review December 21, 2024 19:41
@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this labels Dec 21, 2024
@FoxxoTrystan FoxxoTrystan self-requested a review December 21, 2024 22:46
@FoxxoTrystan FoxxoTrystan added Status: Needs Review Someone please review this and removed Status: Awaiting Changes Do not merge due to requested changes Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. labels Dec 21, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants