Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wedding Essentials #361

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Wedding Essentials #361

merged 3 commits into from
Nov 23, 2024

Conversation

Fansana
Copy link
Owner

@Fansana Fansana commented Nov 18, 2024

🆑

  • add: Added wedding essentials

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Nov 18, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Wedding essentials Wedding Essentials Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

RSI Diff Bot; head commit a28b285 merging into 3b2d14a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Clothing/Under/Gloves/goldring.rsi

State Old New Status
equipped-HAND Added
icon Added

Resources/Textures/Floof/Clothing/Uniforms/weddingdress.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after a28b285

@Memeji
Copy link
Collaborator

Memeji commented Nov 19, 2024

Is this added anywhere? Or just currently in the spawner?

@VividPups
Copy link
Contributor

Is this added anywhere? Or just currently in the spawner?

Honestly I would recommend to put it in a crate, vending machine, or the chaplains vending machine. The Crate and the chaplin vending machine would prevent us having to map a new one on all the maps

FoxxoTrystan
FoxxoTrystan approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR works, there no way for players to get those clothes, only for admins, did you not wanted to intergrate a way for players to access those items?

@Memeji
Copy link
Collaborator

Memeji commented Nov 23, 2024

Add it to the Theater Vendor

@Fansana Fansana merged commit 80e0403 into master Nov 23, 2024
13 checks passed
Floof-Station-Bot added a commit that referenced this pull request Nov 23, 2024
@Floof-Station-Bot
Automatic Changelog Update (#361)
8928cea
@Fansana Fansana mentioned this pull request Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan approved these changes

@Memeji Memeji Awaiting requested review from Memeji Memeji is a code owner

Assignees
No one assigned
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fansana @Memeji @VividPups @FoxxoTrystan