Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypnotemp Plushies #356

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

Cprn-Sprkl
Copy link
Contributor

Description

Adds seven new HypnoTemp Staffer absorbent plushies. They can each hold 30u of liquid and come prefilled with different solutions for each variant. These plushies have been made findable in maintenance closets, maintenance wall lockers, and inside of prize balls.

The solutions have mostly mild and fun benefits such as small amounts of healing, slight speed boosts for a few seconds, and laughter. They're made up of mainly readily available chemicals with the exception of omnizine, which is available in the CMO variant plushie. The amount should be comparable to round start herbals while having no deterministic way of acquiring the CMO variant plushie.

Media

HTPPreview


Changelog

🆑 sprkl

  • add: Seven variants of HypnoTemp Staffer plushies can now be found in station lockers and prize balls.

Adds seven new HypnoTemp absorbent and pre-soaked staffer plushies. Makes them available through locker spawns and prize balls.
Finished the missing descriptions.
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

RSI Diff Bot; head commit 17b0e8d merging into 2e39a10
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Objects/HypnoTempPlushies/staffer_plushies.rsi

State Old New Status
staffer_CE Added
staffer_CMO Added
staffer_Cap Added
staffer_HoP Added
staffer_HoS Added
staffer_LO Added
staffer_Mysta Added

Edit: diff updated after 17b0e8d

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minors changes code wise.
While this is a self-insert, we will talk with the team regarding those.

@FoxxoTrystan FoxxoTrystan added Priority: 3-Low Should be resolved at some point Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. labels Nov 15, 2024
@FoxxoTrystan FoxxoTrystan self-requested a review November 15, 2024 11:19
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fails are valid.

Corrected license to match test requirements.
@FoxxoTrystan FoxxoTrystan self-requested a review November 15, 2024 12:02
@Fansana
Copy link
Owner

Fansana commented Nov 18, 2024

can you add this to the plush vendor?

@Cprn-Sprkl
Copy link
Contributor Author

can you add this to the plush vendor?

Took a look through and the only vendor I saw with plushies was the Pride-o-Mat. There's the prize counter's lathe where you can trade tickets for plushies. Is that the one I should add them to?

The other plushie places I found that they hadn't been added to was the random toy spawner marker, plushie mail, presents, and the lotto. I'd considered making a separate piece of mail with a small ad and one random HypnoTemp plush in it, but I didn't want to end up just adding things forever without submitting first. Should I add them to the possible present spawns?

@FoxxoTrystan
Copy link
Collaborator

While they are in the random prizeball ticket, they are not in the prizevendor.

@Cprn-Sprkl
Copy link
Contributor Author

Added them at 100 tickets each to put them more in line with toys like the water gun.

@FoxxoTrystan
Copy link
Collaborator

Personnaly, pretty sure plushies like these should not be found in maint, well yes but right now we dont have an exact universal plushie spawner for lockers.

In fact, did you add your plushie to the random plushie spawner?

@FoxxoTrystan FoxxoTrystan merged commit bc3b3ba into Fansana:master Nov 21, 2024
12 of 13 checks passed
Floof-Station-Bot added a commit that referenced this pull request Nov 21, 2024
@Fansana Fansana mentioned this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Review Someone please review this Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants