Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round Start Security Magbots #345

Merged
merged 7 commits into from
Nov 23, 2024
Merged

Conversation

ProphetCrow
Copy link
Contributor

@ProphetCrow ProphetCrow commented Nov 12, 2024

Description

This is an expansion / overwrite to #335 . I attempted to reach out to the original creator over discord, however, they appear to have left the community and the message did not go thru.

The overall goal of this PR is to make security magboots more accessible round start. This PR aims to put a pair of magboots in every security hardsuit filled locker, including Corpsmen, Warden, HoS, and the normal security suit storage lockers.

Why? I believe security should have this resource round start. Delta-P from spacing and lubebombs can sometimes be impossible to deal with as security, and other departments that have access to space suits, such as salvage and engineering, already start with magboots in their lockers. I dont believe its a logical stretch to give it to security, who may have one of the highest needs for this kind of item.
As it currently stands, these items are locked behind a techfab recipe, and that puts the urgency to print these boots in the hands of the warden or head of security, depending on the map. These players may not even realize these items are even in the game, or you may often run into games where there is no warden or a HoS; making ready access to these items impossible.
In addition, DeltaV released this version of the magboots on their server to a widely positive review. My PR expands upon this release and reuses the sprite from their fork, which is my resprite that I personally made to match the uniforms of the security officers.

Potential concerns: I attempted to add a delayuse component on the boots to prevent people from robustly spamming the slip-proof feature while minimizing the 20% movement speed reduction, but I wasnt able to get it to work at my junior level of programming so I opt'd to leave it alone. I was able to identify it could be related to the ToggleClothing system but its currently above my skill level.
Seeing how this playerbase is more MRP, I personally dont believe we will run into a situation of a player abusing the slip proof function of the magboots to metagame security that often, but I do know this was a potential balance concern.
Overall, I believe the addition of these boots are a net positive to the security department. I believe their introduction into suitstorage lockers is well overdue.


image
image
image


🆑 Crow

  • tweak: Adjusted security magboots to spawn in appropriate suit storage lockers

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Nov 12, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Round start security magbots Round Start Security Magbots Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

RSI Diff Bot; head commit de9569f merging into 3b2d14a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Clothing/Shoes/Boots/combatMagboots.rsi

State Old New Status
equipped-FEET-vox Removed
equipped-FEET Removed
icon-on Removed
icon Removed
inhand-left Removed
inhand-right Removed
on-equipped-FEET-vox Removed
on-equipped-FEET Removed
on-inhand-left Removed
on-inhand-right Removed

Resources/Textures/Floof/Clothing/Shoes/Boots/magboots-security.rsi

State Old New Status
equipped-FEET Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added
on-equipped-FEET Added
on-inhand-left Added
on-inhand-right Added

Edit: diff updated after de9569f

@Fansana
Copy link
Owner

Fansana commented Nov 13, 2024

I'm personally against this, the shoes at this point offer an armor bonus which would make them a must take. If they are available round start they have to lose this bonus.

@fenndragon
Copy link
Contributor

Normally I would say either it's magboots or armor. But no other boot in the game to my knowledge has any form of armor. I agree with fasana on this one

@BluCottonCandy
Copy link

The thing is security should not be wearing Magboots/hard suits (excluding warden and HOS) unless they are required.

The armor they add is insignificant, and if we tried to add security gas masks (which do also have armor) you all would have the same complaint, yet no one's ever had an issue with them as they truly add no bonus.

I am all for this PR because not having them round start is stupid.

@fenndragon
Copy link
Contributor

The thing is security should not be wearing Magboots/hard suits (excluding warden and HOS) unless they are required.

The armor they add is insignificant, and if we tried to add security gas masks (which do also have armor) you all would have the same complaint, yet no one's ever had an issue with them as they truly add no bonus.

I am all for this PR because not having them round start is stupid.

we would not have the same complaint, other armored leg pieces have been denied for the same reason, and actually having magboots and hardsuits is not actually against any rules or guidelines, it's just not general practice for any of the above to have hardsuits when in code green.

@ProphetCrow
Copy link
Contributor Author

ProphetCrow commented Nov 14, 2024

I'm personally against this, the shoes at this point offer an armor bonus which would make them a must take. If they are available round start they have to lose this bonus.

The armor bonus was stripped, Ive overwritten the original PR entirely. Ill double check the code though.

Edit: The armor bonus was effectively removed by deleting Resources/Prototypes/Floof/Entities/Clothing/Shoes/Combatmags.yml and replacing it with Resources/Prototypes/Floof/Entities/Clothing/Shoes/magboots.yml

My version does not provide an armor bonus and is identical to normal magnetic boots, down to the material cost.

image

@FoxxoTrystan FoxxoTrystan added Status: Needs Review Someone please review this Status: Needs Discussion Must be discussed Priority: 3-Low Should be resolved at some point Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. labels Nov 14, 2024
@VividPups
Copy link
Contributor

VividPups commented Nov 19, 2024

My discord vividpups if you would like to reach me. I will join the community back soon (discord-wise) I am the OG creator for the boots

Yes I was thinking that Combat magboots could be used for an Highcost starting option but I didn't want to get into Loadout stuff. I will probably make an Captain one soon.

@VividPups
Copy link
Contributor

And please do not removed the SESWC

@VividPups
Copy link
Contributor

also have this been tested on VOX so that it lines up correctly with them

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Prototypes/Floof/Recipes/Lathes/security.yml(18,3) Field "parent" not found in "Content.Shared.Research.Prototypes.LatheRecipePrototype".

Fix valid test fails

@Fansana
Copy link
Owner

Fansana commented Nov 23, 2024

Dunno why the test is complaining about the saltern docking but I think it doesn't matter.

@Fansana Fansana requested a review from FoxxoTrystan November 23, 2024 16:17
@Memeji Memeji merged commit 2386612 into Fansana:master Nov 23, 2024
14 checks passed
Floof-Station-Bot added a commit that referenced this pull request Nov 23, 2024
@Fansana Fansana mentioned this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants