Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: map.compute_centroids fail for maps with no fragments #486

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

AhmetNSimsek
Copy link
Collaborator

import siibra
mp = siibra.get_map('julich 3', 'mni152')
mp.compute_centroids()

expected: computes the centroids using the volumes of the map.
actual: cannot fetch the mask

This PR fixes this issue

@AhmetNSimsek AhmetNSimsek added bug Something isn't working important labels Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #486 (b5d64cd) into main (5a0e6b3) will increase coverage by 0.62%.
Report is 149 commits behind head on main.
The diff coverage is 27.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   36.81%   37.44%   +0.62%     
==========================================
  Files          61       61              
  Lines        5421     5651     +230     
==========================================
+ Hits         1996     2116     +120     
- Misses       3425     3535     +110     
Files Coverage Δ
siibra/configuration/configuration.py 42.35% <ø> (ø)
siibra/core/atlas.py 85.71% <ø> (+1.23%) ⬆️
siibra/core/region.py 45.61% <100.00%> (+1.31%) ⬆️
siibra/features/connectivity/__init__.py 83.33% <100.00%> (ø)
...ibra/features/connectivity/tracing_connectivity.py 75.00% <100.00%> (ø)
siibra/features/image/__init__.py 100.00% <100.00%> (ø)
siibra/features/tabular/layerwise_cell_density.py 37.20% <ø> (+0.25%) ⬆️
siibra/locations/boundingbox.py 19.88% <ø> (ø)
...a/features/connectivity/functional_connectivity.py 55.55% <0.00%> (ø)
siibra/features/image/volume_of_interest.py 68.42% <66.66%> (-0.33%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AhmetNSimsek AhmetNSimsek requested a review from xgui3783 October 11, 2023 13:16
@AhmetNSimsek AhmetNSimsek merged commit 5aeeabd into main Oct 11, 2023
16 checks passed
@AhmetNSimsek AhmetNSimsek deleted the fix_map_compute_centroids branch October 11, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants