Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: siibra version & fix regional map #148

Merged
merged 1 commit into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/common/data_handlers/compounds/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def write_desc(filename, obj, **kwargs):
space: _space.Space = siibra.spaces[space_id]
region = siibra.get_region(parcellation_id, region_id)
region_filename = f"{region.key}.nii.gz"
regional_map = region.fetch_regional_map(space, siibra.MapType.STATISTICAL)
regional_map = region.get_regional_map(space, siibra.MapType.STATISTICAL).fetch()
zipfile.writestr(region_filename, gzip.compress(regional_map.to_bytes()))
write_desc(f'{region_filename}.info.md', region)
except Exception as e:
Expand Down
2 changes: 1 addition & 1 deletion api/common/data_handlers/volumes/parcellationmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def get_parcellation_labelled_map(parcellation_id: str, space_id: str, region_id
volume_data = None
if region_id is not None:
region = siibra.get_region(parcellation_id, region_id)
volume_data = region.fetch_regional_map(space_id, siibra.MapType.LABELLED)
volume_data = region.get_regional_map(space_id, siibra.MapType.LABELLED).fetch()
else:
labelled_map = siibra.get_map(parcellation_id, space_id, siibra.MapType.LABELLED)
assert labelled_map is not None, f"{error_text} returns None"
Expand Down
2 changes: 1 addition & 1 deletion requirements/siibra.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# siibra==1.0a4
git+https://github.com/FZJ-INM1-BDA/siibra-python.git@5789433407a70f921b7e03055533f043750c08c9
git+https://github.com/FZJ-INM1-BDA/siibra-python.git@d5fa00f
plotly