feat: add dataset to space

FZJ-INM1-BDA · Oct 17, 2023 · 86bb8c7 · 86bb8c7
1 parent 8ebf022
commit 86bb8c7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/api/models/core/space.py b/api/models/core/space.py
@@ -4,6 +4,7 @@
     Model as _CommonCoordinateSpaceModel,
     AxesOrigin,
 )
+from api.models._retrieval.datasets import EbrainsDatasetModel
 from typing import List, Optional
 from pydantic import Field
 
@@ -16,3 +17,7 @@ class CommonCoordinateSpaceModel(_CommonCoordinateSpaceModel, ConfigBaseModel, t
         min_items=1,
         title='defaultImage',
     )
+    datasets: Optional[List[EbrainsDatasetModel]] = Field(
+        None,
+        alias="datasets",
+    )
diff --git a/api/serialization/core/space.py b/api/serialization/core/space.py
@@ -33,4 +33,5 @@ def space_to_model(space: Space, **kwargs) -> CommonCoordinateSpaceModel:
         release_date=str(date(2015, 1, 1)),
         short_name=space.shortname,
         version_identifier=space.name,
+        datasets=[instance_to_model(ds) for ds in (space.datasets or [])]
     )
diff --git a/test/serialization/test_space.py b/test/serialization/test_space.py
@@ -5,10 +5,12 @@
 from api.models.core.space import CommonCoordinateSpaceModel
 
 all_spaces = [s for s in spaces]
+spaces_without_ds = ("ICBM 2009c nonl asym", "Allen Mouse CCF v3", "hcp32k")
 
 @pytest.mark.parametrize("space", all_spaces)
 def test_space(space: Space):
     model = instance_to_model(space)
     assert isinstance(model, CommonCoordinateSpaceModel)
     model.dict()
-
+    if model.short_name not in spaces_without_ds:
+        assert len(model.datasets) > 0