Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning For Individual Port Declaration #223

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Warning For Individual Port Declaration #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions FABulous/fabric_generator/file_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,10 +667,10 @@ def parseFile(

with open(f"{json_file}", "r") as f:
data_dict = json.load(f)
# Default yosys list names added.

modules = data_dict.get("modules", {})
filtered_ports: dict[str, IO] = {}
# Gatheres port name and direction, filters out configbits as they show in ports.
# Gathers port name and direction, filters out configbits as they show in ports.
for module_name, module_info in modules.items():
ports = module_info["ports"]
for port_name, details in ports.items():
Expand All @@ -684,6 +684,12 @@ def parseFile(
bits = details.get("bits", [])
filtered_ports[port_name] = (direction, bits)

if individually_declared:
logger.warning(
f"Ports in {filename} have been individually declared rather than as a vector."
)
logger.warning("Ports will not be concatenated during fabric generation.")

param_defaults = module_info.get("parameter_default_values")
if param_defaults and "NoConfigBits" in param_defaults:
noConfigBits = param_defaults["NoConfigBits"]
Expand Down
Loading