Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning For Individual Port Declaration #223

Conversation

A-Kibats
Copy link

@A-Kibats A-Kibats commented Aug 8, 2024

PR adds warning for Individual Port Declaration as suggested by @KelvinChung2000.

Example:

image

-Edit-

Message is now ...Individually declared rather than as a vector.

Copy link
Collaborator

@IAmMarcelJung IAmMarcelJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I just have these two small remarks.

FABulous/fabric_generator/file_parser.py Outdated Show resolved Hide resolved
FABulous/fabric_generator/file_parser.py Outdated Show resolved Hide resolved
@A-Kibats A-Kibats force-pushed the FABulous2.0-development branch 2 times, most recently from 9c2a795 to 460db08 Compare August 8, 2024 13:18
@A-Kibats A-Kibats force-pushed the FABulous2.0-development branch from 460db08 to b2872a2 Compare August 8, 2024 13:20
@A-Kibats
Copy link
Author

A-Kibats commented Aug 8, 2024

Added the suggestions and squashed commit. Cheers.

@KelvinChung2000 KelvinChung2000 merged commit f6a7c12 into FPGA-Research:FABulous2.0-development Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants