Implement basic gesture detection to delete commands #6470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Adds a basic gesture detection to allow you to delete commands while in command mode. This is in particular useful when you do not use hotkeys. Often I find myself in the situation that I miss placed a build order. When you do not use hotkeys, this looks like:
In particular, step 3 can be time consuming. With this feature it can be simplified to:
And problem solved. See it also in action:
gesture-detection.mp4
Testing done on the proposed changes
All is tested during development. All the code is annotated. Debugging is in particular trivial since it requires no reloading of the game - see also the nice trick with using
OnDirty
andOnReload
of the module 😃 !Additional context
Requires FAForever/FA-Binary-Patches#90, which is available on the FAF Develop game type. To test this pull request you'll need to start a lobby using the FAF Develop game type to retrieve the correct executable.
With thanks to @4z0t for his time and effort.
Checklist