Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize air factory roll off times #5640

Merged
merged 11 commits into from
Nov 29, 2023

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Nov 5, 2023

In this PR I try to normalize the roll off behaviour for all Air Factories. My aims are:

Tasks:

  • Evaluate the efficiency of the different roll off animations
  • Make the Seraphim Air Factory build engineers at the same rate as Land Factories and the Aeon Air factory
  • Add new roll off points where it makes sense, and improves pathfinding
  • Add Garanas' automatic rotation towards the optimal rollout point for the Seraphim Air Factories
  • Add Garanas' automatic rotation towards the optimal rollout point for the UEF Air Factories
  • Add Garanas' automatic rotation towards the optimal rollout point for the Cybran Air Factories
  • Unify the formatting for RollOffPoints in the .bp

Not possible without changing the animation:

  • Make the UEF Air Factory build at the same rate as Land Factories and the Aeon Air factory
  • Make the Cybran Air Factory build at the same rate as Land Factories and the Aeon Air factory

Explanation of the changes:

  • Roll out points: The Aeon and Seraphim get an additional roll out point. They used to only be able to release engineers out of their sides, which, looking at their models, did not make much sense. Now engineers can move straight out of both factories, but can still choose to take one of the sides, if it makes sense for them. This makes pathfinding less complicated.
  • Automatic rotation of engineers towards the optimal rollout point: I introduced this for the Seraphim Air Factory for now.
  • Build-Cooldowns: To bring the Seraphim Air Factory in line with the Aeon Air Factory, I decreased its cooldown by 4 ticks. From my testing, both factories behave exactly the same now. To bring the Cybran and UEF Air Factories in line with these two, the animations of both will have to be sped up, which is controversial and still up to debate.

@Basilisk3 Basilisk3 marked this pull request as draft November 5, 2023 17:18
@Basilisk3 Basilisk3 changed the title Draft: Attempt to normalize Air Factory roll off Draft: Attempt to normalize Air Factory roll off times + add new roll off points Nov 5, 2023
…Seraphim Air Factories (with thanks to Garanas)
@Garanas
Copy link
Member

Garanas commented Nov 6, 2023

This is looking good 😃 !

@Garanas Garanas added this to the Development iteration V milestone Nov 6, 2023
@Garanas Garanas added the area: balance related to units balance label Nov 6, 2023
@Basilisk3
Copy link
Collaborator Author

This is looking good 😃 !

Thanks, I will try to implement your engineer-roation feature to the factories that don't have it yet, to close #5625. I hope that is okay.

@Garanas
Copy link
Member

Garanas commented Nov 6, 2023

Of course it is - looking forward to the end result!

@Basilisk3
Copy link
Collaborator Author

Concerning the automatic engineer turning: I have managed to introduce it for the Seraphim Air Factory, but I am having problems with the UEF and Cybran Air Factories. Both will lower their platforms, then turn the engineer and let it move out correctly. But afterwards both factories won't raise their platforms anymore.

If fixing this is more complicated, it would probably be better if this is done in another PR.

@Garanas
Copy link
Member

Garanas commented Nov 7, 2023

I'll see what I can find for you

@Basilisk3 Basilisk3 marked this pull request as ready for review November 20, 2023 23:31
@Basilisk3
Copy link
Collaborator Author

I did some maintenance.

@Garanas Garanas changed the title Draft: Attempt to normalize Air Factory roll off times + add new roll off points Normalize air factory roll off times Nov 29, 2023
@Garanas Garanas merged commit d79d353 into FAForever:deploy/fafdevelop Nov 29, 2023
2 checks passed
@Garanas
Copy link
Member

Garanas commented Nov 29, 2023

@Basilisk3 The current changes are a great start, great work 👍

@Basilisk3 Basilisk3 deleted the AirFactory_RollOff branch November 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants