Skip to content

Commit

Permalink
Merge pull request #46001 from truph01/fix/43797
Browse files Browse the repository at this point in the history
Fix: Send invoice - System message for invoice edit is missing Reply in thread for invoice sender
  • Loading branch information
cristipaval authored Aug 23, 2024
2 parents 156f0a2 + 66c2ace commit cb9dec1
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
3 changes: 3 additions & 0 deletions src/libs/API/parameters/SendInvoiceParams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ type SendInvoiceParams = RequireAtLeastOne<
transactionThreadReportID: string;
companyName?: string;
companyWebsite?: string;
createdIOUReportActionID: string;
createdReportActionIDForThread: string;
reportActionID: string;
},
'receiverEmail' | 'receiverInvoiceRoomID'
>;
Expand Down
25 changes: 23 additions & 2 deletions src/libs/actions/IOU.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ type SendInvoiceInformation = {
reportPreviewReportActionID: string;
transactionID: string;
transactionThreadReportID: string;
createdIOUReportActionID: string;
createdReportActionIDForThread: string;
reportActionID: string;
onyxData: OnyxData;
};

Expand Down Expand Up @@ -1944,6 +1947,9 @@ function getSendInvoiceInformation(
);

return {
createdIOUReportActionID: optimisticCreatedActionForIOUReport.reportActionID,
createdReportActionIDForThread: optimisticCreatedActionForTransactionThread?.reportActionID ?? '-1',
reportActionID: iouAction.reportActionID,
senderWorkspaceID,
receiver,
invoiceRoom: chatReport,
Expand Down Expand Up @@ -3582,10 +3588,25 @@ function sendInvoice(
companyName?: string,
companyWebsite?: string,
) {
const {senderWorkspaceID, receiver, invoiceRoom, createdChatReportActionID, invoiceReportID, reportPreviewReportActionID, transactionID, transactionThreadReportID, onyxData} =
getSendInvoiceInformation(transaction, currentUserAccountID, invoiceChatReport, receiptFile, policy, policyTagList, policyCategories, companyName, companyWebsite);
const {
senderWorkspaceID,
receiver,
invoiceRoom,
createdChatReportActionID,
invoiceReportID,
reportPreviewReportActionID,
transactionID,
transactionThreadReportID,
createdIOUReportActionID,
createdReportActionIDForThread,
reportActionID,
onyxData,
} = getSendInvoiceInformation(transaction, currentUserAccountID, invoiceChatReport, receiptFile, policy, policyTagList, policyCategories, companyName, companyWebsite);

const parameters: SendInvoiceParams = {
createdIOUReportActionID,
createdReportActionIDForThread,
reportActionID,
senderWorkspaceID,
accountID: currentUserAccountID,
amount: transaction?.amount ?? 0,
Expand Down

0 comments on commit cb9dec1

Please sign in to comment.