fix param types

Expensify · Aug 22, 2024 · 66c2ace · 66c2ace
1 parent c1f0ecd
commit 66c2ace
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/libs/API/parameters/SendInvoiceParams.ts b/src/libs/API/parameters/SendInvoiceParams.ts
@@ -20,10 +20,9 @@ type SendInvoiceParams = RequireAtLeastOne<
         transactionThreadReportID: string;
         companyName?: string;
         companyWebsite?: string;
-        iouReportActionID?: string;
-        createdIOUReportActionID?: string;
-        createdReportActionIDForThread?: string;
-        reportActionID?: string;
+        createdIOUReportActionID: string;
+        createdReportActionIDForThread: string;
+        reportActionID: string;
     },
     'receiverEmail' | 'receiverInvoiceRoomID'
 >;

diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts
@@ -111,9 +111,8 @@ type SendInvoiceInformation = {
     reportPreviewReportActionID: string;
     transactionID: string;
     transactionThreadReportID: string;
-    iouReportActionID: string;
     createdIOUReportActionID: string;
-    createdReportActionIDForThread?: string;
+    createdReportActionIDForThread: string;
     reportActionID: string;
     onyxData: OnyxData;
 };
@@ -1971,10 +1970,9 @@ function getSendInvoiceInformation(
 
     return {
         createdIOUReportActionID: optimisticCreatedActionForIOUReport.reportActionID,
-        createdReportActionIDForThread: optimisticCreatedActionForTransactionThread?.reportActionID,
+        createdReportActionIDForThread: optimisticCreatedActionForTransactionThread?.reportActionID ?? '-1',
         reportActionID: iouAction.reportActionID,
         senderWorkspaceID,
-        iouReportActionID: iouAction.reportActionID,
         receiver,
         invoiceRoom: chatReport,
         createdChatReportActionID: optimisticCreatedActionForChat.reportActionID,
@@ -3621,7 +3619,6 @@ function sendInvoice(
         reportPreviewReportActionID,
         transactionID,
         transactionThreadReportID,
-        iouReportActionID,
         createdIOUReportActionID,
         createdReportActionIDForThread,
         reportActionID,
@@ -3632,7 +3629,6 @@ function sendInvoice(
         createdIOUReportActionID,
         createdReportActionIDForThread,
         reportActionID,
-        iouReportActionID,
         senderWorkspaceID,
         accountID: currentUserAccountID,
         amount: transaction?.amount ?? 0,