Remove extra deletion

ExpediaGroup · Nov 21, 2024 · 4c45de2 · 4c45de2
1 parent 9bf7248
commit 4c45de2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...ry/src/main/java/com/expediagroup/beekeeper/scheduler/apiary/service/SchedulerApiary.java b/...ry/src/main/java/com/expediagroup/beekeeper/scheduler/apiary/service/SchedulerApiary.java
@@ -72,12 +72,10 @@ public void scheduleBeekeeperEvent() {
         scheduler.scheduleForHousekeeping(entity);
       } catch (BeekeeperIcebergException e) {
         log.warn("Iceberg table are not supported in Beekeeper. Deleting message from queue", e);
-        beekeeperEventReader.delete(beekeeperEvent);
       } catch (Exception e) {
         throw new BeekeeperException(format(
             "Unable to schedule %s deletion for entity, this message will go back on the queue",
-            entity.getLifecycleType()),
-            e);
+            entity.getLifecycleType()), e);
       }
     }
     beekeeperEventReader.delete(beekeeperEvent);

diff --git a/...rc/test/java/com/expediagroup/beekeeper/scheduler/apiary/service/SchedulerApiaryTest.java b/...rc/test/java/com/expediagroup/beekeeper/scheduler/apiary/service/SchedulerApiaryTest.java
@@ -171,7 +171,7 @@ public void icebergValidatorThrowsException() {
     verify(icebergValidator).throwExceptionIfIceberg(databaseName, tableName);
     verifyNoInteractions(pathSchedulerService);
     verifyNoInteractions(tableSchedulerService);
-    verify(beekeeperEventReader, times(2)).delete(event.get()); // We need to fix this, we are deleting twice, not sure why
+    verify(beekeeperEventReader).delete(event.get());
   }
 
   @Test