clean-up add comment

ExpediaGroup · Nov 21, 2024 · 9bf7248 · 9bf7248
1 parent d16bc0a
commit 9bf7248
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/...leanup/src/main/java/com/expediagroup/beekeeper/metadata/cleanup/context/CommonBeans.java b/...leanup/src/main/java/com/expediagroup/beekeeper/metadata/cleanup/context/CommonBeans.java
@@ -81,8 +81,7 @@ public CloseableMetaStoreClientFactory metaStoreClientFactory() {
 
   @Bean
   Supplier<CloseableMetaStoreClient> metaStoreClientSupplier(
-      CloseableMetaStoreClientFactory metaStoreClientFactory,
-      HiveConf hiveConf) {
+      CloseableMetaStoreClientFactory metaStoreClientFactory, HiveConf hiveConf) {
     String name = "beekeeper-metadata-cleanup";
     return new HiveMetaStoreClientSupplier(metaStoreClientFactory, hiveConf, name);
   }
@@ -103,8 +102,7 @@ public DeletedMetadataReporter deletedMetadataReporter(
 
   @Bean(name = "hiveTableCleaner")
   MetadataCleaner metadataCleaner(
-      DeletedMetadataReporter deletedMetadataReporter,
-      IcebergValidator icebergValidator) {
+      DeletedMetadataReporter deletedMetadataReporter, IcebergValidator icebergValidator) {
     return new HiveMetadataCleaner(deletedMetadataReporter, icebergValidator);
   }
 
@@ -141,8 +139,7 @@ public S3Client s3Client(AmazonS3 amazonS3, @Value("${properties.dry-run-enabled
   @Bean(name = "s3PathCleaner")
   PathCleaner pathCleaner(
       S3Client s3Client,
-      BytesDeletedReporter bytesDeletedReporter,
-      IcebergValidator icebergValidator) {
+      BytesDeletedReporter bytesDeletedReporter, IcebergValidator icebergValidator) {
     return new S3PathCleaner(s3Client, new S3SentinelFilesCleaner(s3Client), bytesDeletedReporter, icebergValidator);
   }
 

diff --git a/...up/src/test/java/com/expediagroup/beekeeper/metadata/cleanup/context/CommonBeansTest.java b/...up/src/test/java/com/expediagroup/beekeeper/metadata/cleanup/context/CommonBeansTest.java
@@ -161,8 +161,7 @@ void verifyS3pathCleaner() {
   @Test
   public void verifyExpiredMetadataHandler() {
     ExpiredMetadataHandler expiredMetadataHandler = commonBeans.expiredMetadataHandler(hiveClientFactory,
-        metadataRepository,
-        metadataCleaner, pathCleaner);
+        metadataRepository, metadataCleaner, pathCleaner);
     assertThat(expiredMetadataHandler).isInstanceOf(ExpiredMetadataHandler.class);
   }
 

diff --git a/...agroup/beekeeper/scheduler/apiary/generator/ExpiredHousekeepingMetadataGeneratorTest.java b/...agroup/beekeeper/scheduler/apiary/generator/ExpiredHousekeepingMetadataGeneratorTest.java
@@ -1,5 +1,5 @@
 /**
- * Copyright (C) 2019-2022 Expedia, Inc.
+ * Copyright (C) 2019-2024 Expedia, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,7 +33,6 @@
 import java.util.List;
 import java.util.Map;
 
-
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;

diff --git a/...rc/test/java/com/expediagroup/beekeeper/scheduler/apiary/service/SchedulerApiaryTest.java b/...rc/test/java/com/expediagroup/beekeeper/scheduler/apiary/service/SchedulerApiaryTest.java
@@ -171,7 +171,7 @@ public void icebergValidatorThrowsException() {
     verify(icebergValidator).throwExceptionIfIceberg(databaseName, tableName);
     verifyNoInteractions(pathSchedulerService);
     verifyNoInteractions(tableSchedulerService);
-    verify(beekeeperEventReader, times(2)).delete(event.get());
+    verify(beekeeperEventReader, times(2)).delete(event.get()); // We need to fix this, we are deleting twice, not sure why
   }
 
   @Test