Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused os variable from the matrix #76

Closed
wants to merge 1 commit into from
Closed

Remove unused os variable from the matrix #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, ubuntu-20.04]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/cache@v3 step would need to be updated as well :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, no. Sorry! It wasn't using matrix.os

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused, it s creating the matrics for those OS for all those versions correctly. see #79 where we test against both OS all those versions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. What you are seeing that looks correct to you is nothing but a label. Take a look into the logs and you can see how every job is running on top of ubuntu-latest under the hood.

Open the logs for this job, navigate through "Set up job" > "Operating System" and confirm that it's employing 22.04 despite you would assume it would be 20.04.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reporting this. The fix is not to remove but instead fixing it. I think I see what might be missing

" runs-on: ${{ matrix.os }}" need to be added

elixir_version: [1.12.3, 1.13.3, 1.14.1]
otp_version: [24, 25]
exclude:
Expand Down