Remove unused os variable from the matrix #76
Conversation
The top-level `runs-on` value has been pinned to `ubuntu-latest` and this `os` variable has no place to live when running tests, resulting in only doubling the workload for no benefits. Although we can actually start to test on the both os versions, this commit does not go for it and chooses to use `ubuntu-latest` solely. This is because it is hard to imagine that the os version affects the outcome as long as the versions of otp and elixir are set, and this is what the popular libraries like plug and phoenix use as their strategy[^1][^2]. [^1]: https://github.com/elixir-plug/plug/blob/v1.15.2/.github/workflows/ci.yml [^2]: https://github.com/phoenixframework/phoenix/blob/v1.7.10/.github/workflows/ci.yml
| @@ -17,7 +17,6 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-22.04, ubuntu-20.04] | |||
There was a problem hiding this comment.
actions/cache@v3 step would need to be updated as well :)
There was a problem hiding this comment.
ah, no. Sorry! It wasn't using matrix.os
There was a problem hiding this comment.
I am confused, it s creating the matrics for those OS for all those versions correctly. see #79 where we test against both OS all those versions
There was a problem hiding this comment.
No. What you are seeing that looks correct to you is nothing but a label. Take a look into the logs and you can see how every job is running on top of ubuntu-latest under the hood.
Open the logs for this job, navigate through "Set up job" > "Operating System" and confirm that it's employing 22.04 despite you would assume it would be 20.04.
There was a problem hiding this comment.
thanks for reporting this. The fix is not to remove but instead fixing it. I think I see what might be missing
" runs-on: ${{ matrix.os }}" need to be added
|
Close as fixed with #81 |
The top-level
runs-onvalue has been pinned toubuntu-latestand thisosvariable has no place to live when running tests, resulting in only doubling the workload for no benefits.Although we can actually start to test on the both os versions, this commit does not go for it and chooses to use
ubuntu-latestsolely.This is because it is hard to imagine that the os version affects the outcome as long as the versions of otp and elixir are set, and this is what the popular libraries like plug and phoenix use as their strategy12.
Footnotes
https://github.com/elixir-plug/plug/blob/v1.15.2/.github/workflows/ci.yml ↩
https://github.com/phoenixframework/phoenix/blob/v1.7.10/.github/workflows/ci.yml ↩