test(panel): add token theming tests #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonailea
reviewed
May 29, 2024
| targetProp: "inlineSize", | ||
| }, | ||
| "--calcite-panel-action-background-color": { | ||
| shadowSelector: `calcite-action >>> .button`, |
There was a problem hiding this comment.
I think this can just be "calcite-action"
There was a problem hiding this comment.
I think there is a confusion with naming here. The --calcite-panel-action-background-color token is only used for close action rendered when closable is set to true & the trigger of calcite-action-menu when header-menu-actions are slotted.
Should we separate these out and refactor names to be more specific ?
alisonailea
requested changes
May 29, 2024
| targetProp: "--calcite-action-background-color", | ||
| }, | ||
| "--calcite-panel-action-background-color-hover": { | ||
| shadowSelector: `calcite-action >>> .button`, |
| state: { hover: { attribute: "class", value: `button` } }, | ||
| }, | ||
| "--calcite-panel-action-background-color-active": { | ||
| shadowSelector: `calcite-action >>> .button`, |
alisonailea
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Add token theming tests for
panelcomponent.