Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(panel): add token theming tests #9442

Merged
merged 2 commits into from
May 30, 2024
Merged

test(panel): add token theming tests #9442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70bd89e
test(panel): add token theming tests
anveshmekala May 28, 2024
2fb0a35
remove piercing operator for sub-component query
anveshmekala May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions packages/calcite-components/src/components/panel/panel.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
slots,
t9n,
} from "../../tests/commonTests";
import { ComponentTestTokens, themed } from "../../tests/commonTests/themed";
import { CSS, SLOTS } from "./resources";

const panelTemplate = (scrollable = false) =>
Expand Down Expand Up @@ -424,4 +425,146 @@ describe("calcite-panel", () => {
expect(await panel.getProperty("closed")).toBe(false);
expect(await container.isVisible()).toBe(true);
});

describe("theme", () => {
const panelHTML = html`
<calcite-panel height-scale="s" closable heading="panel" description="slotted with header actions and action-bar">
<calcite-action text="banana" text-enabled icon="banana" slot="header-menu-actions"></calcite-action>
<calcite-action text="measure" text-enabled icon="measure" slot="header-menu-actions"></calcite-action>
<calcite-action label="icon left" icon="left" slot="header-actions-start"></calcite-action>
<calcite-action label="icon left" icon="left" slot="header-actions-end"></calcite-action>
<calcite-action-bar slot="action-bar">
<calcite-action-group>
<calcite-action text="Add" icon="plus"> </calcite-action>
<calcite-action text="Save" icon="save"> </calcite-action>
<calcite-action text="Layers" icon="layers"> </calcite-action>
</calcite-action-group>
</calcite-action-bar>
<div slot="content-top">Slot for a content-top.</div>
<p>Slotted content!</p>
<p style="height: 400px">Hello world!</p>
<p style="height: 400px">Hello world!</p>
<p style="height: 400px">Hello world!</p>
<div slot="content-bottom">Slot for a content-bottom.</div>
<p slot="footer">Slotted content!</p>
<calcite-fab slot="fab"></calcite-fab>
</calcite-panel>
`;

describe("default", () => {
const tokens: ComponentTestTokens = {
"--calcite-panel-spacing-block-end": {
shadowSelector: `.${CSS.contentBottom}`,
targetProp: "paddingBlockEnd",
},
"--calcite-panel-spacing-block-start": {
shadowSelector: `.${CSS.contentTop}`,
targetProp: "paddingBlockStart",
},
"--calcite-panel-height": {
selector: "calcite-panel",
targetProp: "blockSize",
},
"--calcite-panel-width": {
selector: "calcite-panel",
targetProp: "inlineSize",
},
"--calcite-panel-action-background-color": [
{
shadowSelector: `calcite-action[title='Close']`,
targetProp: "--calcite-action-background-color",
},
{
shadowSelector: `calcite-action[slot='trigger']`,
targetProp: "--calcite-action-background-color",
},
],
"--calcite-panel-action-background-color-hover": [
{
shadowSelector: `calcite-action[title='Close']`,
targetProp: "--calcite-action-background-color",
state: { hover: { attribute: "class", value: `button` } },
},
{
shadowSelector: `calcite-action[slot='trigger']`,
targetProp: "--calcite-action-background-color",
state: { hover: { attribute: "class", value: `button` } },
},
],
"--calcite-panel-action-background-color-active": [
{
shadowSelector: `calcite-action[title='Close']`,
targetProp: "--calcite-action-background-color",
state: { press: { attribute: "class", value: `button` } },
},
{
shadowSelector: `calcite-action[slot='trigger']`,
targetProp: "--calcite-action-background-color",
state: { press: { attribute: "class", value: `button` } },
},
],
"--calcite-panel-action-menu-border-color": {
shadowSelector: "calcite-action-menu",
targetProp: "--calcite-action-menu-border-color",
},
"--calcite-panel-action-menu-text-color": {
shadowSelector: "calcite-action-menu",
targetProp: "--calcite-action-menu-text-color",
},
"--calcite-panel-background-color": [
{
shadowSelector: `.${CSS.container}`,
targetProp: "backgroundColor",
},
{
shadowSelector: `.${CSS.contentWrapper}`,
targetProp: "backgroundColor",
},
],
"--calcite-panel-border-color": [
{
shadowSelector: `.${CSS.header}`,
targetProp: "borderBlockEndColor",
},
{
shadowSelector: `.${CSS.headerContainerBorderEnd}`,
targetProp: "borderBlockEndColor",
},
{
shadowSelector: `.${CSS.footer}`,
targetProp: "borderBlockStartColor",
},
],
"--calcite-panel-description-text-color": {
shadowSelector: `.${CSS.description}`,
targetProp: "color",
},
"--calcite-panel-fab-z-index": {
shadowSelector: `.${CSS.fabContainer}`,
targetProp: "zIndex",
},
"--calcite-panel-footer-background-color": {
shadowSelector: `.${CSS.footer}`,
targetProp: "backgroundColor",
},
"--calcite-panel-footer-space": {
shadowSelector: `.${CSS.footer}`,
targetProp: "paddingBlockStart",
},
"--calcite-panel-header-background-color": {
shadowSelector: `.${CSS.header}`,
targetProp: "backgroundColor",
},
"--calcite-panel-header-z-index": {
shadowSelector: `.${CSS.header}`,
targetProp: "zIndex",
},
"--calcite-panel-heading-text-color": {
shadowSelector: `.${CSS.heading}`,
targetProp: "color",
},
};
themed(panelHTML, tokens);
});
});
});
1 change: 0 additions & 1 deletion packages/calcite-components/src/components/panel/panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
* @prop --calcite-panel-header-background-color: Specifies the component header's background color.
* @prop --calcite-panel-header-border-block-end: [Deprecated] No longer necessary. Specifies the component header's block end border.
* @prop --calcite-panel-header-z-index: Specifies the component header's z-index.
* @prop --calcite-panel-header-z-index: Specifies the component header's z-index.
* @prop --calcite-panel-heading-text-color: Specifies the component's heading text color.
*
*/
Expand Down