Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Update jellyfish #2397

Merged
merged 1 commit into from
Jan 14, 2024
Merged

[CHORE] Update jellyfish #2397

merged 1 commit into from
Jan 14, 2024

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Jan 12, 2024

No description provided.

else {
let Ok(signature) = TYPES::SignatureKey::sign(
&self.private_key,
vid_disperse.payload_commitment.as_ref().as_ref(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as_ref().as_ref() yikes. wish that could be cleaner 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this could be fixed Jellyfish side. Just add AsRef<[u8]> or Into<Vec<u8>> or something like that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbearer jbearer merged commit f5e2fdf into main Jan 14, 2024
14 checks passed
@jbearer jbearer deleted the update/jellyfish branch January 14, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants