Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergonomic conversion of HasherNode to byte slice #471

Open
ggutoski opened this issue Jan 24, 2024 · 2 comments
Open

Ergonomic conversion of HasherNode to byte slice #471

ggutoski opened this issue Jan 24, 2024 · 2 comments

Comments

@ggutoski
Copy link
Contributor

In order to get a &[u8] from a HasherNode downstream users must do .as_ref().as_ref(). Example:
EspressoSystems/HotShot#2397 (comment)

The acceptable number of .as_ref() to force upon downstream users is at most 1.

@akonring
Copy link
Contributor

akonring commented Apr 3, 2024

Might be missing something but it is not clear to me why this cannot be handled in a simple manner on the Hotshot side like this: EspressoSystems/HotShot#2892

@ggutoski
Copy link
Contributor Author

ggutoski commented Apr 4, 2024

In that case, it seems there is no problem. I'm a bit surprised it works now with only one .as_ref(). I wonder whether somebody quietly slipped in a fix without noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants