Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with "bad" keyword in object and function definition #554

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Fix issue with "bad" keyword in object and function definition #554

merged 2 commits into from
Oct 25, 2018

Conversation

Bob-Thomas
Copy link
Contributor

Bob-Thomas referenced this pull request in fungiboletus/eslint-plugin-angular Jul 11, 2018
@fungiboletus
Fix EmmanuelDemey#507
34036eb
@xdjinnx
Copy link
Collaborator

xdjinnx commented Jul 11, 2018

Is it possible to add a test for this?

@Bob-Thomas
Copy link
Contributor Author

@xdjinnx Working on it

@Bob-Thomas
Copy link
Contributor Author

@xdjinnx Added a tiny test for keyword use inside an object.

Bob-Thomas
Bob-Thomas commented Jul 11, 2018
View reviewed changes
test/avoid-scope-typos.js
});

/** Test for using none reserved keywords as a function name */
nonReservedBad.forEach(function(b) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test for #507

@Bob-Thomas
Copy link
Contributor Author

@xdjinnx any reason the travis is failing ?

@Bob-Thomas Bob-Thomas mentioned this pull request Jul 11, 2018
Closed
@Bob-Thomas Bob-Thomas changed the title Fix issue with new keyword in object Fix issue with "bad" keyword in object and function definition Jul 11, 2018
@Bob-Thomas
Copy link
Contributor Author

@Gillespie59 @xdjinnx

@EmmanuelDemey EmmanuelDemey merged commit 798a156 into EmmanuelDemey:development Oct 25, 2018
@EmmanuelDemey
Copy link
Owner

Thanks @Bob-Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bob-Thomas @xdjinnx @EmmanuelDemey