Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken scope type when I use .new as a property name #553

Closed
Bob-Thomas opened this issue Jul 11, 2018 · 3 comments
Closed

broken scope type when I use .new as a property name #553

Bob-Thomas opened this issue Jul 11, 2018 · 3 comments

Comments

@Bob-Thomas
Copy link
Contributor

When I setup an object like

{
 new: 'new',
 old: 'old'
}

my eslint fails with a ambiguous error [Error - 11:12:01 PM] TypeError: Cannot read property 'name' of undefined. This is not a eslint failure but a broken check on https://github.com/Gillespie59/eslint-plugin-angular/blob/master/rules/avoid-scope-typos.js#L27.

An easy fix I applied for myself is adding another check if node.parent.object exists.

@Bob-Thomas
Copy link
Contributor Author

Same problem causes another issue #507
Both will be fixed with #554

@Bob-Thomas
Copy link
Contributor Author

@Gillespie59 Any reason my PR is not getting through CI it's been sitting there for 3 months now

@xdjinnx
Copy link
Collaborator

xdjinnx commented Oct 10, 2018

I will look into this as soon as I have time! The PR looks good! I just need to test it and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants