Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve office world #75

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Conversation

larodriguez22
Copy link
Collaborator

@larodriguez22 larodriguez22 commented Aug 19, 2024

🎉 New feature

Related to #60

Summary

Improvement of office world by using blender and pbr textures.

Screencast.from.08-19-2024.05.09.46.PM.webm

Test it

To run:

ros2 launch andino_gz andino_gz.launch.py world_name:=office.sdf

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! 🚀
I will try it locally!

andino_gz/models/office/model.config Outdated Show resolved Hide resolved
andino_gz/models/office/model.config Outdated Show resolved Hide resolved
andino_gz/models/office/model.sdf Outdated Show resolved Hide resolved
andino_gz/worlds/office.sdf Outdated Show resolved Hide resolved
@francocipollone
Copy link
Collaborator

Before merging try to fix DCO: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md for the commits.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working really good even with the old map's png for navigation

image

One minor comment: I think you are missing one wooden hallway
image

@francocipollone
Copy link
Collaborator

francocipollone commented Aug 22, 2024

Given that you are going to modify a bit the wooden floor, can you check that actually the wooden hallway should be a bit shorter:

For example
image

You can see this in this videos as well click here for video

francocipollone and others added 5 commits August 23, 2024 09:31
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Laura Rodriguez <[email protected]>
@larodriguez22 larodriguez22 force-pushed the larodriguez22/improve_office_world branch from d63ffb9 to c84c49b Compare August 23, 2024 14:35
@larodriguez22
Copy link
Collaborator Author

Before merging try to fix DCO: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md for the commits.

Fixed

@francocipollone francocipollone mentioned this pull request Aug 26, 2024
Signed-off-by: Laura Rodriguez <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Co-authored-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone force-pushed the larodriguez22/improve_office_world branch from d539b96 to 64d4387 Compare August 26, 2024 02:39
Signed-off-by: Franco Cipollone <[email protected]>
Copy link
Collaborator

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome job, we needed to make some changes to the andino_rmf repo, we should try to merge this PR and Ekumen-OS/andino_rmf#27 at the same time.

@francocipollone francocipollone merged commit 714fe4b into humble Aug 27, 2024
3 checks passed
@francocipollone francocipollone deleted the larodriguez22/improve_office_world branch August 27, 2024 06:21
@IDavGal IDavGal mentioned this pull request Nov 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants